-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Implement DeleteCookies for YT Service dock #10710
Conversation
ee1c7e1
to
60ca2b3
Compare
DeleteCookies
for the YT Service dock.DeleteCookies
for YT Service dock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use merge commits to catch up on branch/repo history. Use git rebase
.
Do not use final punctuation in PR titles or commit message subjects (the first line of a commit message).
DeleteCookies
for YT Service dock.08657f3
to
c00c7da
Compare
Done. |
c00c7da
to
ca5b94e
Compare
5effd58
to
1acbc90
Compare
This is still using final punctuation (a period at the end) of the commit message subject.
Could you elaborate on how this enables "centralized cookie management for YouTube/Google account logins"? |
1acbc90
to
46585b0
Compare
Done. Fixed, sorry, I did not realize that was disallowed.
Yes, see #10747. I'm working on another change to improve the chat UX when the user is signed-in, will send the pull request shortly. |
7ffed41
to
3c8a8b4
Compare
For what it's worth, our Contributing Guidelines cover this in the linked "How to Write a Git Commit Message".
Ideally, the context and "why" should be provided here, at least in summary form. If you must point to another PR for additional context, it should be linked in the Motivation section. In this case, this seems more like these changes "enable a future implementation of centralized cookie management" rather than enabling such itself, which was the main point of confusion internally while reviewing this. This by itself only "implements DeleteCookies", and the question brought up in review was, "why?" If you could answer "why?" in the PR's Motivation section, that would be helpful to reviewers. |
Done. Updated the motivation section. |
3c8a8b4
to
9e46850
Compare
9e46850
to
f44f6a1
Compare
Gentle ping for review, please LMK if the PR's motivation section looks better. |
ff5af99
to
0dd305d
Compare
c136a53
to
289bc71
Compare
391c3c3
to
78e112d
Compare
78e112d
to
cd6f7f1
Compare
This will enable centralized cookie management for YouTube/Google account logins for other browser docks using the shared cookie manager.
cd6f7f1
to
7e5a507
Compare
Description
Implement
DeleteCookies
for YT service integration dock, similar to other service integration docks.Motivation and Context
This will enable centralized cookie management for YouTube/Google account logins for other browser docks using the shared cookie manager. The existing YouTube Control Panel browser dock will be migrated to using the shared cookie manager (see #10747) so that sign-in cookies can be shared between YouTube Control Panel and YouTube Live Chat. This will unlock improved creator-facing experience for OBS users of YouTube Live Chat (such as better chat latency, creation end-points for polls, Q&A, moderation capabilities etc).
How Has This Been Tested?
Built OBS locally on Linux workstation, connected YouTube account (via OAuth), disconnected YouTube OAuth, verified no cookies were remaining. For purposes of testing, I copied over cookies from the YTCP cookie manager after logging into YouTube Studio.
Types of changes
Checklist: