Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update d3, Plot, stdlib #370

Merged
merged 2 commits into from
Mar 26, 2024
Merged

update d3, Plot, stdlib #370

merged 2 commits into from
Mar 26, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 26, 2024 •
edited
Loading

depends on observablehq/stdlib#393

TODO:

  • yarn upgrade @observablehq/stdlib

mbostock
mbostock approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approval assuming you update yarn.lock etc.

@Fil
Copy link
Contributor Author

Fil commented Mar 26, 2024

yarn upgrade updated a lot of dependencies, but it looks all right?

mbostock
mbostock requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend only doing a minimal upgrade, not upgrading everything. I don’t currently want to review all the other changes.

@Fil Fil marked this pull request as ready for review March 26, 2024 16:54
@Fil Fil merged commit 286eca3 into main Mar 26, 2024
3 checks passed
@Fil Fil deleted the fil/5-9-8 branch March 26, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock