[Android] Replace SharedPreferences with DataStore Preferences
#629
+194
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@oblador Any idea why the error about Could it be a side-effect of adding Kotlin?! 🤷🏻 |
enahum
reviewed
May 25, 2024
ovitrif
force-pushed
the
refactor/android-data-store
branch
from
7eb93ba
to
75a24b1
Compare
|
@ovitrif Can you update this PR? |
# Conflicts: # KeychainExample/android/build.gradle # README.md # android/build.gradle # android/src/main/java/com/oblador/keychain/KeychainModule.java # android/src/test/java/com/oblador/keychain/KeychainModuleTests.java # build.gradle.kts
Reimplement data store refactoring on version 9.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #628
This PR replaces the usage of
SharedPreferenceswithDataStore.Why
Google is recommending in their official documentation to migrate to
DataStorefromSharedPreferences, and they also provided a very easy-to-use auto-migration tool that will move the data to the newDataStore, then clean up the entries fromSharedPreferences.Their official guide for saving simple data with SharedPreferences displays an alert about this:
For security concerns as well, it is recommended to migrate to DataStore.
How
Calls to read and write to DataStore are forced to run synchronously based on the example provided by the Android team in Use DataStore in synchronous code.
Data Migration
SharedPreferencesMigrationis used to migrate the entries stored in theRN_KEYCHAINshared prefs file to data store. Upon completion, theSharedPreferencesget removed.Testing
junit test were removed from the project