Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SharedPreferences with DataStore Preferences on Android #628

Open
ovitrif opened this issue Mar 14, 2024 · 2 comments · May be fixed by #629
Open

Replace SharedPreferences with DataStore Preferences on Android #628

ovitrif opened this issue Mar 14, 2024 · 2 comments · May be fixed by #629

Comments

@ovitrif
Copy link

ovitrif commented Mar 14, 2024 •
edited
Loading

Hi!

I'm working on an implementation to replace the usage of SharedPreferences with DataStore. It's recommended by Google as seen in Prefer Storing Data with Jetpack DataStore, moreover security-wise there may be concerns about SharedPreferences being deprecated in the longer run.

Since DataStore is tailored to Kotlin, I plan to write the code for it in Kotlin, thus adding Kotlin support to the Android library project.

Hope everything about this is ok with the maintainers 🙏🏻
@ovitrif ovitrif linked a pull request Mar 14, 2024 that will close this issue
Open
@AbhavThakur
Copy link

hi @ovitrif
Can you help me out in understanding if this can lead to app crash .
I am using React Native - 0.73.6. Here, we are using Kotlin and I have checked my android logcat.
Screenshot 2024-03-20 at 4 49 03 PM

@ovitrif
Copy link
Author

ovitrif commented Mar 20, 2024

Hi @AbhavThakur, can you please share the logs part above the screenshot which point to where the error occurred?

Its's this also related somehow to the changes of my PR, #629 ?
I mean, unless you're locally using it, it isn't yet available in react-native-keychain…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] Replace SharedPreferences with DataStore Preferences ovitrif/react-native-keychain
2 participants
@ovitrif @AbhavThakur