Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how extension requests ledger access (don't rely on state sync) #2094

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Refactor how extension requests ledger access (don't rely on state sync) #2094

wants to merge 7 commits into from

Commits on Nov 19, 2024

  1. Rename ledger popup prop

    @lukaw3d @buberdds
    lukaw3d authored and buberdds committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2829f9a View commit details
    Browse the repository at this point in the history

  2. Refactor how extension requests ledger access (don't rely on state sync) 

    Before:
- redux was shared between persistent popup (can request USB permissions) and
  default popup
- persistent popup listed ledger accounts into store
- when reopening default popup listed accounts were kept
- when reopening default popup after clearing listed accounts: all steps repeat

After:
- persistent popup requests permissions
- this gives permissions to default popup too
- when reopening default popup: use new permissions to list accounts from ledger
    @lukaw3d @buberdds
    lukaw3d authored and buberdds committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    39935ef View commit details
    Browse the repository at this point in the history

  3. Handle async TransportWebUSB method

    @buberdds
    buberdds committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cd7ca03 View commit details
    Browse the repository at this point in the history

  4. Move extension logic into external file

    @buberdds
    buberdds committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d6e9686 View commit details
    Browse the repository at this point in the history

  5. Add communication between ext popup and window

    @buberdds
    buberdds committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f93ceb3 View commit details
    Browse the repository at this point in the history

  6. Add changelog

    @buberdds
    buberdds committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c2953ff View commit details
    Browse the repository at this point in the history

  7. Update tests

    @buberdds
    buberdds committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a912342 View commit details
    Browse the repository at this point in the history