Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tried to upgrade docker.io/envoyproxy/envoy #1449

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

tried to upgrade docker.io/envoyproxy/envoy #1449

wants to merge 3 commits into from

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 9, 2023

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 9, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: af1d36f
Status: ✅  Deploy successful!
Preview URL: https://aa9959a9.oasis-wallet.pages.dev
Branch Preview URL: https://lw-upgrade-envoy.oasis-wallet.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CSS stylelint 1 0 0 1.22s
✅ EDITORCONFIG editorconfig-checker 28 0 0.05s
✅ JSON eslint-plugin-jsonc 1 0 0 0.98s
✅ JSON jsonlint 1 0 0.19s
✅ JSON npm-package-json-lint yes no 0.59s
✅ JSON prettier 1 0 0 0.5s
✅ JSON v8r 1 0 4.84s
✅ REPOSITORY checkov yes no 21.54s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 5 0 0 6.23s
✅ TYPESCRIPT eslint 1 0 0 4.76s
✅ YAML prettier 3 0 0 0.6s
✅ YAML v8r 3 0 2.72s
✅ YAML yamllint 3 0 0.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lukaw3d lukaw3d closed this May 10, 2023
@lukaw3d lukaw3d reopened this May 10, 2023
@lukaw3d lukaw3d marked this pull request as draft May 10, 2023 01:23
@lukaw3d lukaw3d changed the title Upgrade envoy tried to upgrade docker.io/envoyproxy/envoy May 10, 2023
@lukaw3d lukaw3d mentioned this pull request May 10, 2023
Open
1 task
@pro-wh
Copy link
Contributor

pro-wh commented May 10, 2023

you said no luck with this? what went wrong?

@lukaw3d
Copy link
Member Author

lukaw3d commented May 10, 2023

don't know, but cypress is failing https://github.com/oasisprotocol/oasis-wallet-web/actions/runs/4932114613/jobs/8814830646?pr=1449

pro-wh
pro-wh reviewed May 10, 2023
View reviewed changes
docker/envoy.yaml Outdated
route:
cluster: oasis_node_grpc
timeout: 0s
max_stream_duration:
grpc_timeout_header_max: 0s
- match:
prefix: '/oasis-core'
prefix: '/oasis-core'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be this same indentation breakage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invisible changes 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-wh pro-wh pro-wh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaw3d @pro-wh