Fix Brave browser off event listeners #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubej
changed the title
lubej
force-pushed
the
ml/fix-brave-off-event-listeners
branch
from
abaf99e
to
6fec739
Compare
lukaw3d
reviewed
Jan 11, 2024
| ethProvider.off('chainChanged', _chainChanged) | ||
| ethProvider.off('connect', _connect) | ||
| ethProvider.off('disconnect', _disconnect) | ||
| ethProvider.off?.('accountsChanged', _accountsChanged) |
There was a problem hiding this comment.
I don't think it's safe to simply not unsubscribe. I think safe options are:
- rewrite listeners so unsubscribing is never needed
- implement unsubscribing inside listeners
- reload page if can't unsubscribe
There was a problem hiding this comment.
Right, didn't want to spend much time on it. Since WalletConnect integration is not decided yet. We can just add Brave as a wallet in WalletConnect options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brave browser does not support off events, docs here: https://wallet-docs.brave.com/ethereum/provider-api/events/