Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message IDs #1447

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve message IDs #1447

wants to merge 1 commit into from

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Dec 6, 2024

  • Make the message IDs unique (there are a few messages with the same ID).
  • Some IDs are misleading - don't correctly depict what the messages are about.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Make the message IDs unique (there are a few messages with the same ID).
Some IDs are misleading - don't correctly depict what the messages are about.
@bocekm bocekm added kind/breaking Indicates this will require major version update tests/all Run the full test suite. Equivalent to `/packit test`. kind/refactor labels Dec 6, 2024
@has-bot
Copy link
Member

has-bot commented Dec 6, 2024

/packit test


Comment generated by an automation.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (940e048) to head (472262c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          72       72           
  Lines        5176     5176           
  Branches      895      895           
=======================================
  Hits         4975     4975           
  Misses        119      119           
  Partials       82       82           
Flag Coverage Δ
centos-linux-7 91.63% <ø> (ø)
centos-linux-8 92.49% <ø> (ø)
centos-linux-9 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Indicates this will require major version update kind/refactor tests/all Run the full test suite. Equivalent to `/packit test`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants