Use debug logging for channel types errors, D3 and WA #5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| response = requests.get( | ||
| channel.config[Channel.CONFIG_BASE_URL] + "/v1/health", headers=self.get_headers(channel) | ||
| ) | ||
|
|
||
| if response.status_code != 200: | ||
| raise requests.RequestException("Could not check api status", response=response) | ||
| HTTPLog.from_exception( |
There was a problem hiding this comment.
@norkans7 why move this logic into each channel type?
There was a problem hiding this comment.
We are no longer rairing the exception here so to keep the Http log created for update API version check we need that here
There was a problem hiding this comment.
ok I see that this only affects two legacy channel types.. it's fine
norkans7
force-pushed
the
logger-debug
branch
from
a6121de
to
b6cb315
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5681 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 570 570
Lines 25881 26259 +378
==========================================
+ Hits 25881 26259 +378 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://textit.sentry.io/issues/6082875470/ too