-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Excellent 3 #1060
Merged
Merged
🚀 Excellent 3 #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rowanseymour
commented
Nov 4, 2021
•
edited
Loading
edited
- Parsing is separate step to evaluation (creates an abstract syntax tree) removing need for different visitor classes (Parse excellent to an abstract syntax tree #1061)
- Better error messages with function calls as functions know their own names (Let Excellent functions know their own name to make better error messages #1059)
- Function equality/inequality fixed (Function equality #1062)
- Add support for anonymous functions in excellent #1063
- Drop unused child.run.* and parent.run.* parts of the context #1064
Let Excellent functions know their own name to make better error messages
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
+ Coverage 86.59% 86.81% +0.21%
==========================================
Files 254 256 +2
Lines 10668 10716 +48
==========================================
+ Hits 9238 9303 +65
+ Misses 1005 991 -14
+ Partials 425 422 -3
Continue to review full report at Codecov.
|
Parse excellent to an abstract syntax tree
Function equality
Add support for anonymous functions in excellent
….status as used subflow splits
Drop unused child.run.* and parent.run.* parts of the context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.