Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new s3x package to replace storage #131

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Add new s3x package to replace storage #131

merged 1 commit into from
Jul 26, 2024

Conversation

rowanseymour
Copy link
Member

We're moving away from storages which can be filesystem for testing, S3 for prod... and using S3 clients for everything with minio for local development and CI (and prod if anyone wants).

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.41%. Comparing base (6120347) to head (bf4c5d0).

Files Patch % Lines
s3x/s3.go 74.35% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   90.86%   90.41%   -0.46%     
==========================================
  Files          45       47       +2     
  Lines        1707     1752      +45     
==========================================
+ Hits         1551     1584      +33     
- Misses        117      123       +6     
- Partials       39       45       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit c85da6a into main Jul 26, 2024
5 of 7 checks passed
@rowanseymour rowanseymour deleted the s3x branch July 26, 2024 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant