Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy handler type for load testing #803

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Add dummy handler type for load testing #803

merged 1 commit into from
Nov 18, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.38%. Comparing base (029f9a3) to head (7f277f1).

Files with missing lines Patch % Lines
handlers/test/handler.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   74.37%   74.38%   +0.01%     
==========================================
  Files         111      112       +1     
  Lines       13476    13493      +17     
==========================================
+ Hits        10023    10037      +14     
- Misses       2718     2720       +2     
- Partials      735      736       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:


time.Sleep(time.Duration(sendDelayMs) * time.Millisecond)

if rand.Intn(100) < errorPercent {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need we to mock the tests so they do not fail randomly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good spot!

@rowanseymour rowanseymour merged commit b9cc901 into main Nov 18, 2024
7 checks passed
@rowanseymour rowanseymour deleted the test_handler branch November 18, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants