Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata fetching for new Facebook contacts #423

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

Robi9
Copy link
Contributor

@Robi9 Robi9 commented Feb 18, 2022

Fix for bug discussed in issue #418

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #423 (aa3bff3) into main (3e4d8e1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   71.89%   71.92%   +0.03%     
==========================================
  Files          95       95              
  Lines        8357     8379      +22     
==========================================
+ Hits         6008     6027      +19     
- Misses       1753     1755       +2     
- Partials      596      597       +1     
Impacted Files Coverage Δ
handlers/facebookapp/facebookapp.go 81.88% <100.00%> (+1.06%) ⬆️
backends/rapidpro/backend.go 67.01% <0.00%> (-0.18%) ⬇️
test.go 32.08% <0.00%> (-0.13%) ⬇️
backend.go 20.00% <0.00%> (ø)
handlers/whatsapp/whatsapp.go 76.95% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4d8e1...aa3bff3. Read the comment docs.

Copy link
Contributor

@norkans7 norkans7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor those repeated to have the same code path instead of 2 entirely code paths.

Copy link
Contributor

@norkans7 norkans7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@rowanseymour rowanseymour merged commit 0f691d8 into nyaruka:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants