Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter organization of quick replies into rows and columns for telegram keyboards #374

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Aug 12, 2021

Does #373 for Telegram. Adds some generic buttony layout stuff we should be able to re-use for other channels that support keyboard things

3e5f9dec-6b26-49f0-951b-479aeb443d3b
7c6448ac-809e-4a86-9d69-c2d0d3625377
b8d934c9-e034-45f9-9800-fbc01f328b6e

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #374 (e1fc6c5) into main (44f12b5) will increase coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   71.21%   72.02%   +0.81%     
==========================================
  Files          93       94       +1     
  Lines        8194     8441     +247     
==========================================
+ Hits         5835     6080     +245     
+ Misses       1756     1749       -7     
- Partials      603      612       +9     
Impacted Files Coverage Δ
handlers/telegram/keyboard.go 100.00% <100.00%> (ø)
handlers/telegram/telegram.go 91.41% <100.00%> (+0.87%) ⬆️
utils/misc.go 77.04% <100.00%> (+10.38%) ⬆️
handlers/facebookapp/facebookapp.go 80.45% <0.00%> (+0.61%) ⬆️
handlers/whatsapp/whatsapp.go 84.50% <0.00%> (+7.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f12b5...e1fc6c5. Read the comment docs.

[][]telegram.KeyboardButton{
{{Text: "A"}, {Text: "B"}, {Text: "C"}, {Text: "D"}},
{{Text: "Chicken"}, {Text: "Fish"}},
{{Text: "Peanut Butter Pickle"}},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericnewcomer for your specific flow needs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy that Peanut Butter Pickle has been immortalized in our git history.

@rowanseymour rowanseymour merged commit 06fb061 into main Aug 16, 2021
@rowanseymour rowanseymour deleted the better_telegram_keyboards branch August 16, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants