Merge pull request #804 from nyaruka/test_error_by_msg_text

TST handler should error sends with msg text \error
nyaruka · Nov 18, 2024 · 9e07701 · 9e07701
2 parents 1b20423 + 15cc1e1
commit 9e07701
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/handlers/test/handler.go b/handlers/test/handler.go
@@ -2,6 +2,7 @@ package test
 
 import (
 	"context"
+	"strings"
 	"time"
 
 	"github.com/nyaruka/courier"
@@ -32,7 +33,7 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen
 
 	time.Sleep(time.Duration(sendDelayMs) * time.Millisecond)
 
-	if random.IntN(100) < errorPercent {
+	if random.IntN(100) < errorPercent || strings.Contains(msg.Text(), "\\error") {
 		return courier.ErrConnectionFailed
 	}
 

diff --git a/handlers/test/handler_test.go b/handlers/test/handler_test.go
@@ -3,6 +3,7 @@ package test
 import (
 	"testing"
 
+	"github.com/nyaruka/courier"
 	. "github.com/nyaruka/courier/handlers"
 	"github.com/nyaruka/courier/test"
 	"github.com/nyaruka/gocommon/random"
@@ -11,11 +12,18 @@ import (
 
 var sendTestCases = []OutgoingTestCase{
 	{
-		Label:            "Plain Send",
-		MsgText:          "Simple Message ☺",
+		Label:            "Normal send",
+		MsgText:          "Hi here",
 		MsgURN:           "tel:+12067791234",
 		ExpectedRequests: []ExpectedRequest{},
 	},
+	{
+		Label:            "Error send",
+		MsgText:          "Hi here \\error",
+		MsgURN:           "tel:+12067791234",
+		ExpectedRequests: []ExpectedRequest{},
+		ExpectedError:    courier.ErrConnectionFailed,
+	},
 }
 
 func TestOutgoing(t *testing.T) {