Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a race when StopAtEOF is called #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix a race when StopAtEOF is called #70

wants to merge 1 commit into from

Commits on Apr 8, 2024

  1. fix a race when StopAtEOF is called 

    Currently when StopAtEOF is called, and we previously encountered an
EOF already, we stop reading the file immediately.  However when
tailing a file, new data might have become available in the meantime,
before the StopAtEOF is called.  The watcher might however not have
notified us about that yet.

Instead of exiting immediately if that happens, and leaving the data
that's already in the file unread, continue iterating until we get
the *next* EOF, as we can be reasonably sure that that's the EOF the
user meant to stop at, making sure to read all the data that has been
written by the time StopAtEOF is called.
    @tgummerer
    tgummerer committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7eba873 View commit details
    Browse the repository at this point in the history