Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error "accessing the caller property of a function" on IE11 #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IlyaZha
Copy link

@IlyaZha IlyaZha commented May 30, 2019

We use observable and observer from your library. After this fix library started working on IE11.

@solkimicreb
Copy link
Member

solkimicreb commented May 30, 2019

Thanks for your contribution! I am a bit hesitant about merging this though.

This lib will never work in IE11 since it does not support Proxies (and other ES6 features). In fact, this is only an issue which may pop up in unsupported browsers - like IE11 - which did not properly implement the function caller related ES6 changes.

I would rather do a quick support check in the project entry point and log a more meaningful warning in case of unsupported browsers. What's your opinion?

Side note: list of supported platforms is here

@IlyaZha
Copy link
Author

IlyaZha commented May 31, 2019

So, it's working in IE11 (may be due to babel, I don't know for sure) . If you will not merge this fix, we would just use our patched version of lib.
I have read list of unsupported browsers before, but right now we can not refuse IE11 users.

@solkimicreb
Copy link
Member

I will look into this tomorrow, sorry for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants