Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[readme] remove avn from readme #3469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[readme] remove avn from readme #3469

wants to merge 1 commit into from
+1 −3

Conversation

andrew-chang-dewitt
Copy link

@andrew-chang-dewitt andrew-chang-dewitt commented Nov 13, 2024 •
edited
Loading

avn is archived (see repo) and should probably no longer be recommended by nvm.

@andrew-chang-dewitt @ljharb
[readme] remove avn from readme
2fd83a0 
`avn` is archived ([see repo](https://github.com/direnv/direnv)) and should probably no longer be recommended by nvm.

This also adds a solution using `direnv` and proposes a possible `.envrc` to use.
See [wbyoung/avn#109](wbyoung/avn#109 (comment)) for more suggested `.envrc` files.
ljharb
ljharb reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty big chunk of code to include. probably should be wrapped in a <details>, but either way i think it needs to be polished a bit, and made POSIX-compliant (ie, no bash-specific syntax)

README.md Show resolved Hide resolved
@andrew-chang-dewitt
Copy link
Author

andrew-chang-dewitt commented Nov 13, 2024 •
edited
Loading

this is a pretty big chunk of code to include. probably should be wrapped in a <details>, but either way i think it needs to be polished a bit, and made POSIX-compliant (ie, no bash-specific syntax)

Good point. I think it might actually be even better to limit this PR to avn no longer being maintained & remove the direnv recommendation. I might put it in a second PR and open it later after some testing.

@ljharb
Copy link
Member

ljharb commented Nov 13, 2024

That sounds like a great plan!

@andrew-chang-dewitt andrew-chang-dewitt changed the title docs: remove avn from readme & add a direnv based solution docs: remove avn from readme Nov 13, 2024
@andrew-chang-dewitt
Copy link
Author

Should have everything not about avn removed from this now.

@ljharb ljharb changed the title docs: remove avn from readme [readme] remove avn from readme Nov 15, 2024
@ljharb ljharb closed this Nov 15, 2024
@ljharb ljharb reopened this Nov 15, 2024
@ljharb ljharb closed this Nov 18, 2024
@ljharb ljharb reopened this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
informational
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-chang-dewitt @ljharb