Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open wrong filepath located at network drive for Windows #3323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ukyouz
Copy link

@ukyouz ukyouz commented Oct 10, 2024

Description

Let's say in Windows, we map a Network Drive at Z: to \\share\data\.
Then open nvim in, for example, Z:\\code.

Folder structure for code is like:

code/
  - test.c
  - main.c

Bug reproduce steps:

  1. Open test.c in Neovim.
  2. Query a tag with Telescope tags command
  3. Select a tag located in main.c
  4. WRONG filepath will be opened
    something like absolute path of \share\data\code\main.c is open but actually we want .\main.c.

Maybe it is better to fix the path expansion for entry.path but I can not found where that happens, so just workaround using the relative path entry.filename.

Type of change

  • Bug fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

  • Follow the reproduce steps and verify the bug is fixed.
  • Open a project located in normal disk, and follow the reproduce steps to verify it still works.

Configuration:

  • Neovim version (nvim --version): 0.9.5
  • Operating system and version: Windows 11

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant