Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entry_index): prevent recursive indexing on overrides #3297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamestrew
Copy link
Contributor

When indexing into an entry inside of the override function, the same key you are overriding, this causes an infinitely recursive indexing.

eg.

local opts = {
  entry_index = {
    text = function(entry)
      -- accessing the same key you're overriding in the override
      -- function will lead to stack overflow

      return "foobar " .. entry.text -- bad
    end,
  }
}

This change will let the entries keep track of indexes that have been overridden and prevent recursive indexing.

When indexing into an entry inside of the override function, the same
key you are overriding, this causes an infinitely recursive indexing.

eg.
```lua
local opts = {
  entry_index = {
    text = function(entry)
      -- accessing the same key you're overriding in the override
      -- function will lead to stack overflow

      return "foobar " .. entry.text -- bad
    end,
  }
}
```

This change will let the entries keep track of indexes that have been
overridden and prevent recursive indexing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant