Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize UCX & gRPC apps #579

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Reorganize UCX & gRPC apps #579

merged 5 commits into from
Nov 13, 2024

Conversation

mocsharp
Copy link
Contributor

@mocsharp mocsharp commented Nov 11, 2024 •
edited
Loading

Reorg distributed applications into the following:

└── applications
    └── distributed
        ├── grpc
        │   └── grpc_h264_endoscopy_tool_tracking
        └── ucx
            ├── ucx_endoscopy_tool_tracking
            └── ucx_h264_endoscopy_tool_tracking

tbirdso
tbirdso reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! A couple of small comments/questions

dev_container Outdated Show resolved Hide resolved
...uted/ucx/ucx_h264_endoscopy_tool_tracking/python/h264_endoscopy_tool_tracking_distributed.py Show resolved Hide resolved
applications/distributed/ucx/CMakeLists.txt
# limitations under the License.


add_holohub_application(ucx_endoscopy_tool_tracking DEPENDS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjomier Note that we may need to update the test dashboard to match rename

@mocsharp mocsharp force-pushed the vchang/reorg-distributed-apps branch 2 times, most recently from c1b04a3 to fcaf19c Compare November 12, 2024 20:32
@mocsharp
Reorganize UCX & gRPC apps
d5f8ec4 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
Fix lint issues
12bd62d 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
Remove unwanted changes
9cfa6bb 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
Fix replayer allocator arg name
05c0caf 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
Rename links and launch profiles
64983e4 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp force-pushed the vchang/reorg-distributed-apps branch from fcaf19c to 64983e4 Compare November 12, 2024 20:32
@mocsharp mocsharp self-assigned this Nov 12, 2024
@mocsharp mocsharp mentioned this pull request Nov 12, 2024
Open
tbirdso
tbirdso approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is this ready for merge?

@mocsharp
Copy link
Contributor Author

Looks good to me. Is this ready for merge?

Yes, please.

@tbirdso tbirdso merged commit 3edbcf6 into nvidia-holoscan:main Nov 13, 2024
3 checks passed
@mocsharp mocsharp deleted the vchang/reorg-distributed-apps branch November 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

@jjomier jjomier Awaiting requested review from jjomier

Assignees

@mocsharp mocsharp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mocsharp @tbirdso