-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Add MONAI bundle operator #533
base: main
Are you sure you want to change the base?
[WIP]Add MONAI bundle operator #533
Conversation
Signed-off-by: binliu <[email protected]>
Thanks for this WIP PR. Just wonder if you have looked at the operators already in operators/medical_imaging/operators. This MONAI bundle operator is already there, which in turn was source from MONAI Deploy App SDK. If this PR is to showcase building an example using the existing operators, or enhancing a existing app, please state so clearly. As it stands now, many of the files look to be copied of existing ones already in HoloHub |
Hi @MMelQin thanks for you quick reply. I saw the operators/medical_imaging/operators in the code repo. And yes it's using a MONAI Deploy App SDK. However, MONAI core has developed new feature to utilize the bundle more flexible and I have described it here. Now I am trying to refactor the bundle operator with this new feature. Will also move the issue here and add more context to this PR. |
Perfect! I also chair the MONAI Deploy App SDK, and would like to invite you to one of the weekly meetings. The MONAI Bundle operator in MD App SDK and here in HoloHub indeed was developed when MONAI Bundle 1.1 was about to be release. Updating this operator has been on the map for a long time, but there are other priorities, besides, MONAI Bundle is likely going through another revision. Please start with what's already in the Holohub medical imaging operators, where MONAI Bundle Operator already exists, and enhance as needed. Better yet, please first do it in MONAI Deploy App SDK since the SDK is released as Pypi package and more users can benefit from it. HoloHub does acknowledge using MD App SDK code according to the license. |
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Sure, will try to update the MONA deploy part too. |
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: binliu <[email protected]>
Add the first version of MONAI bundle operator.