Fix CMOD Makefile calling system GCC linker instead of user GCC #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, if you were interested in adding support for newer compiler for CMOD, you could consider upgrading Algorithmic C in cmod/hls/include. I checked this version https://github.com/hlslibs/ac_types which worked with GCC 8.1. At least one problem was missing 'template' keyword which was added in version 3.7.2 (https://github.com/hlslibs/ac_types/blob/master/include/ac_fixed.h#L410) |
|
note: added new commit that should allow run |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not big problem, but I think it's just overlooked use of
$(CC). I checked withgrep -Rw CC, and it's defined nowhere therefore it defaults to/usr/bin/ccwhich is 'out of control'.Good idea would be defining
CC := $(GCC)in make/common.make or somewhere else.