Apply suggestions from code review

Co-authored-by: Benedikt Franke <[email protected]>

docs/master/performance/query-caching.md

@@ -17,11 +17,12 @@ APQ is enabled by default, but depends on query caching being enabled.
 
 ## Query validation caching
 
-Lighthouse can cache the result of the query validation process as well. It only caches queries without errors.
+Lighthouse can cache the result of the query validation process as well.
+It only caches queries without errors.
 `QueryComplexity` validation can not be cached as it is dependent on the query, so it is always executed.
 
-Query validation caching is disabled by default. You can enable it by setting `validation_cache.enable` to `true` in the
-configuration in `config/lighthouse.php`.
+Query validation caching is disabled by default.
+You can enable it by setting `validation_cache.enable` to `true` in `config/lighthouse.php`.
 
 ## Testing caveats
 

src/LighthouseServiceProvider.php

@@ -101,7 +101,6 @@ public function provideSubscriptionResolver(FieldValue $fieldValue): \Closure
             }
         });
 
-        // $this->app->bind(ProvidesValidationRules::class, ValidationRulesProvider::class);
         $this->app->bind(ProvidesValidationRules::class, CacheableValidationRulesProvider::class);
 
         $this->commands(self::COMMANDS);

src/Support/Contracts/ProvidesCacheableValidationRules.php

@@ -7,7 +7,7 @@ interface ProvidesCacheableValidationRules extends ProvidesValidationRules
     /**
      * A set of rules for the first query validation step.
      *
-     * These rules would be executed first and their result would be cached.
+     * These rules are executed first and their result is cached.
      *
      * @return array<string, \GraphQL\Validator\Rules\ValidationRule>
      */
@@ -16,7 +16,7 @@ public function cacheableValidationRules(): array;
     /**
      * A set of rules for the second query validation step.
      *
-     * These rules would always be executed and not cached.
+     * These rules are always be executed and not cached.
      *
      * Returning `null` enables all available rules.
      * Empty array skips query validation entirely.

tests/Integration/ValidationCachingTest.php

@@ -9,7 +9,7 @@
 use Tests\TestCase;
 use Tests\Utils\Queries\Foo;
 
-class ValidationCachingTest extends TestCase
+final class ValidationCachingTest extends TestCase
 {
     public function testEnabled(): void
     {

tests/Unit/Schema/AST/DocumentASTTest.php

@@ -114,6 +114,6 @@ public function testBeSerialized(): void
         $this->assertInstanceOf(SchemaExtensionNode::class, $schemaExtension);
         $this->assertInstanceOf(DirectiveNode::class, $schemaExtension->directives[0]);
 
-        $this->assertEquals($documentAST->hash, $reserialized->hash);
+        $this->assertSame($documentAST->hash, $reserialized->hash);
     }
 }