Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move keyfeatures to a grid of cards #728

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

jarrodmillman
Copy link
Member

Building on functionality from the v0.11 release. The keyfeature panel for the homepage will be removed in a future theme release. This is part of our large effort to adopt styling from pydata-sphinx-theme where possible. It also makes the frontpage behave more like the other pages.

You can see more examples of cards (in a grid) here:

Here is what they look like in PST:

This will also make it easier to modify project homepages without having to override layouts/index.html.

The styling is a little different than before due to adopting pydata-sphinx-theme styling. But that styling is being used on many community sites and is being reviewed for accessibility.

The Scientific Python websites and scipy.org have already been updated. For example, see scipy/scipy.org#558

@steppi @rgommers Note that this change will need to be made for all translations going forward.

(Once this is merged we plan to start converting the other special homepage sections---i.e., shell, casestudies, and tabs---to shortcodes called from content//_index.md.)

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 59cd8bd
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/65d4f5c4b7d0ad0008f65749
😎 Deploy Preview https://deploy-preview-728--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@InessaPawson InessaPawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarrodmillman All the changes look great!

@InessaPawson InessaPawson merged commit 764ee22 into numpy:main Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants