Fixup typing #136
Merged
Fixup typing #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklam
reviewed
Jul 23, 2024
| @@ -705,16 +706,23 @@ def rlookup(self, region_block: RegionBlock, item: Any) -> Any: | |||
| else: | |||
| raise KeyError(f"Item {item} not found in subregion or parent") | |||
|
|
|||
| def codegen(self, block: Any) -> list[ast.AST]: | |||
| def codegen(self, block: Any) -> MutableSequence[ast.AST]: | |||
There was a problem hiding this comment.
Instead of casting result of codegen(), does it always return list[ast.stmt]?
There was a problem hiding this comment.
no, it may also generate a list with ast.stmt and ast.expr mixed. I.e. a list of ast.AST nodes. But list isn't covariant and since both ast.expr and ast.stmt are subclasses of ast.AST we need to use MutableSequence. NB: I also tried using Sequence but that fails to type the list.append correctly.
sklam
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup typing leftovers from #135