Sqlpackage CLI wrpper #1209
Sqlpackage CLI wrpper #1209
Conversation
|
Typo in filename, and markdown file should be removed. |
| { | ||
| "name": "AzureSharedAccessSignatureToken", | ||
| "type": "string", | ||
| "help": "Azure shared access signature (SAS) token. See [SqlPackage for Azure Synapse Analytics](sqlpackage-for-azure-synapse-analytics.md#publish-import-data)." |
There was a problem hiding this comment.
Markdown links are not supported. Should be using <a href>
| { | ||
| "name": "AzureStorageRootPath", | ||
| "type": "string", | ||
| "help": "Storage root path within the container. Without this property, the path defaults to `servername/databasename/timestamp/`. See [SqlPackage for Azure Synapse Analytics](sqlpackage-for-azure-synapse-analytics.md#publish-import-data)." |
There was a problem hiding this comment.
Markdown inline code is not supported, should be using <c>. Same goes for a couple of other properties, that can be considered as code (and which aren't even using markdown inline code).
| { | ||
| "name": "DoNotDropObjectType", | ||
| "type": "string", | ||
| "help": "An object type that should not be dropped when DropObjectsNotInSource is true. Valid object type names are Aggregates, ApplicationRoles, Assemblies, AssemblyFiles, AsymmetricKeys, BrokerPriorities, Certificates, ColumnEncryptionKeys, ColumnMasterKeys, Contracts, DatabaseOptions, DatabaseRoles, DatabaseTriggers, Defaults, ExtendedProperties, ExternalDataSources, ExternalFileFormats, ExternalTables, Filegroups, Files, FileTables, FullTextCatalogs, FullTextStoplists, MessageTypes, PartitionFunctions, PartitionSchemes, Permissions, Queues, RemoteServiceBindings, RoleMembership, Rules, ScalarValuedFunctions, SearchPropertyLists, SecurityPolicies, Sequences, Services, Signatures, StoredProcedures, SymmetricKeys, Synonyms, Tables, TableValuedFunctions, UserDefinedDataTypes, UserDefinedTableTypes, ClrUserDefinedTypes, Users, Views, XmlSchemaCollections, Audits, Credentials, CryptographicProviders, DatabaseAuditSpecifications, DatabaseEncryptionKeys, DatabaseScopedCredentials, Endpoints, ErrorMessages, EventNotifications, EventSessions, LinkedServerLogins, LinkedServers, Logins, MasterKeys, Routes, ServerAuditSpecifications, ServerRoleMembership, ServerRoles, ServerTriggers, ExternalStreams, ExternalStreamingJobs, DatabaseWorkloadGroups, WorkloadClassifiers, ExternalLibraries, ExternalLanguages. This property may be specified multiple times to indicate multiple options." |
There was a problem hiding this comment.
This (and others) should use <ul> and <li>.
There was a problem hiding this comment.
I don't understand why? Looks like this is generating the required documentations
There was a problem hiding this comment.
Valid object type names are %enumeration%
There was a problem hiding this comment.
Do you mean using
- and
- can make the valid values into strongly typed nuke string enumerations ?
|
There are a lot of properties that are unused, ie. don't define a |
Typo fixed in file name
Please correct me if wrong, I think you are referring to the delegates array. The purpose of such fields is to be used as KeyValue pair in the format {Key}={Value} Which is defined in the parent json's |
|
Ah, right! I didn't see that. FYI, if different tasks share a lot of common properties, you could use something like this: https://github.com/nuke-build/nuke/blob/develop/source/Nuke.Common/Tools/ReSharper/ReSharper.json#L14 |
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
0686f32
to
d6aab06
Compare
matkoch
force-pushed
the
develop
branch
5 times, most recently
from
0231425
to
d806295
Compare
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
7066bbe
to
985de83
Compare
matkoch
force-pushed
the
develop
branch
4 times, most recently
from
0719711
to
6fe1e3b
Compare
matkoch
force-pushed
the
develop
branch
2 times, most recently
from
6d02194
to
4bfee84
Compare
matkoch
force-pushed
the
develop
branch
4 times, most recently
from
85998da
to
01b2b6e
Compare
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
e652c9a
to
6ed9e4d
Compare
I confirm that the pull-request: