-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for LÖVE 11 #19
base: master
Are you sure you want to change the base?
Conversation
…bably a longstanding bug brought to the fore by the fact that loveframes now crashes if the choice value is nil
…ual to the expected version.
…that it was created/exists
Thanks for your work on this PR! sfxr is pretty useful and it's nice to have a working UI. Edit: Nevermind. If you run
package.path = package.path .. ";../?.lua"
|
One change missed in this update was using the supported version of getDirectoryItems. The callback is no longer supported so the save/load dialogs never showed any files. Fix: idbrii@0da9d70 |
This changeset contains two categories of fixes:
For (1) the changes:
a. update to the 11.x fork of LoveFrames that is being maintained by @linux-man
b. change any color literals to use components in the range (0,1) instead of (0,255)
c. move usage of deprecated
love.filesystem
functions to current versions.d. fix a field name that was probably incorrect for a long time but now causes an assertion failure in LoveFrames.
e. reflect changes to LoveFrames skin API
For (2) the changes:
a. Make the version check not fail if the expected version == the found version when loading a lua file.
b. Replace references to globals
freq
andbits
that are not defined insfxr.lua
in the wav export code with localsrate
anddepth
.