Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reader macros when merging EDN files #39

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

hlship
Copy link
Contributor

@hlship hlship commented Oct 15, 2024

  • Please check if the PR fulfills these requirements
  • [ x] There is an open issue describing the problem that this pr intents to solve.
    • [ x] You have a descriptive commit message with a short title (first line).
  • [ x] Tests for the changes have been added (for bug fixes / features).
  • [ x] Docs have been added / updated (for bug fixes / features).
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior?

The tool throws an exception when attempting to merge EDN files containing undefined reader macros.

  • What is the new behavior (if this is a feature change)?

The EDN files are merged, and reader macros are maintained (via clojure.core/tagged-literal).

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

@hlship hlship self-assigned this Oct 15, 2024
@hlship hlship marked this pull request as ready for review October 15, 2024 22:25
@hlship
Copy link
Contributor Author

hlship commented Oct 15, 2024

I don't know why the workflow bits are failing, I bumped the versions to no avail.

@alan-ghelardi alan-ghelardi merged commit 25f6aa7 into master Oct 16, 2024
0 of 2 checks passed
@alan-ghelardi alan-ghelardi deleted the hls/20241015-fix-merge-issue branch October 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants