Model of the diode trigger used for RNO-G #675

lpyras · 2024-04-27T20:48:10Z

This PR contains a model of the diode trigger behaviour by filtering the trace in the bandpass of 80-200 MHz and then taking the power of the pulse and integrating it over 11ns. Since the trigger threshold is supposed to be noise riding, a multiple of the SNR value of the trace is used as a threshold. Usually the trigger operates in a 2/3 or 2/6 coincidence mode with a time window of 60 ns.

anelles

Please check why this fails and take a look at my documentation comments.

NuRadioReco/framework/trigger.py

anelles · 2024-05-15T11:53:14Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+        trace: array of floats
+            the signal trace
+        window: float
+            the integration window


In what units? Time? Samples?

NuRadioReco/modules/trigger/radiant_aux_trigger.py

NuRadioReco/framework/trigger.py

NuRadioReco/modules/trigger/radiant_aux_trigger.py

colemanalan · 2024-05-19T18:50:07Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+    def get_threshold(self, trace, threshold_sigma, int_window):
+        noise_samples = int(130 * self.sampling_rate)
+        noise = self.get_power_int_trace(trace[10:noise_samples], int_window)
+        threshold = threshold_sigma * np.std(noise)
+        return threshold


Even if it is redundant, I would put 130 * units.ns * self.sampling_rate. Is 130 a "magic number" on the radiant? If yes, say that, if not, say why 130.

This fn needs docstrings

it is within the first half of our trace, so that's the number. I agree, it need explanation. :)

colemanalan · 2024-05-19T18:50:25Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+    """
+    """


Add docstrings

colemanalan · 2024-05-19T18:53:35Z

NuRadioReco/framework/parameters.py

@@ -58,6 +58,7 @@ class channelParameters(Enum):
    signal_ray_type = 16        #: type of the ray propagation path of the signal received by this channel. Options are direct, reflected and refracted
    signal_receiving_azimuth = 17   #: the azimuth angle of direction at which the radio signal arrived at the antenna
    block_offsets = 18 #: 'block' or pedestal offsets. See `NuRadioReco.modules.RNO_G.channelBlockOffsetFitter`
+    radiant_aux_trigger_threshold = 19  #: the threshold of the radiant aux trigger


Generally, I don't like the use of this parameter since it only allows you to run one trigger. What if I want to run a simulation where I am testing the e.g. V_eff of several different trigger thresholds? I guess only the last one will be recorded

Also, you directly store (or could store) the threshold in trigger = RadiantAUXTrigger(trigger_name, threshold_sigma, int_window, number_coincidences, coinc_window, triggered_channels) when you run the trigger

Since the trigger threshold is adjusted for each trace (mimicking the threshold servo in the field) the threshold differs for each channel and each event. I don't really know how to store that. This was one idea, but maybe that's overdoing it and we dont need to save it.

colemanalan · 2024-05-19T18:54:46Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+        threshold: float
+            the threshold as value of sigma (a factor of snr)
+
+        window: float


int_window

needs units: time? bins?

sorry, time :) I added it.

Sorry you still didn't address the first fixing. The parameter is int_winow instead of window. I am looking now and this also applies to the get_power_int_trace function

colemanalan · 2024-05-19T18:58:29Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+        self.sampling_rate = station.get_channel(det.get_channel_ids(station.get_id())[0]).get_sampling_rate()
+        dt = 1. / self.sampling_rate


You should get the channel ID from triggered_channels. You don't know that the first entry in det.get_channel_ids will be a channel that has the sampling rate that you want.

Since you allow None, I guess you have to put an if statement here like you did below

True, thanks! :)

colemanalan · 2024-05-20T01:26:54Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+            (triggered_bins, threshold) = self.get_trigger_response(channel.get_trace(), threshold_sigma, int_window)
+            triggered_bins_channels.append(triggered_bins)
+
+            if True in triggered_bins:


np.any will be faster (optional comment/change)

thanks, I change that :)

colemanalan · 2024-05-20T13:25:07Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+            if True in triggered_bins:
+                channels_that_passed_trigger.append(channel.get_id())
+
+            channel.set_parameter(chp.radiant_aux_trigger_threshold, threshold)


Again, I would set this in the RadiantAUXTrigger object unless there is a good reason to put this here

NuRadioReco/modules/trigger/radiant_aux_trigger.py

anelles · 2024-08-08T12:45:54Z

With 8 days on the new job, @lpyras now of course has time to fix this, right?
Please don't wait too long. This is an essential module.

lpyras · 2024-08-14T21:49:45Z

I finally cleaned this up and added units and docstrings.
Two more questions:

Should we keep calculating the threshold on single channel and event level since this is how the servoing in the field works, or should we calculate the threshold once and use the same for all channels, which is probably faster.
The threshold is given as a multiple of the noise rms. Should the voltage value (here power integrated, so (V^2/ns)) be stored? What would be the best option?

Thanks!

colemanalan

Just two more documentation things. But thanks for the updates already.
Functionally, this looks good

colemanalan · 2024-08-16T16:15:27Z

NuRadioReco/modules/trigger/radiant_aux_trigger.py

+        threshold: float
+            the threshold as value of sigma (a factor of snr)
+
+        window: float


Sorry you still didn't address the first fixing. The parameter is int_winow instead of window. I am looking now and this also applies to the get_power_int_trace function

NuRadioReco/modules/trigger/radiant_aux_trigger.py

lpyras · 2024-08-16T19:45:03Z

I finally cleaned this up and added units and docstrings. Two more questions:

Should we keep calculating the threshold on single channel and event level since this is how the servoing in the field works, or should we calculate the threshold once and use the same for all channels, which is probably faster.

The threshold is given as a multiple of the noise rms. Should the voltage value (here power integrated, so (V^2/ns)) be stored? What would be the best option?

Thanks!

@cg-laser any opinions on this?

lpyras · 2024-09-02T19:00:47Z

@cg-laser , @fschlueter and me discussed that we abandon this PR, since the trigger is basically a power integrated trigger with a passband filter and a set threshold. I will change to power integration trigger such that it can take a frequency range as input. In the future, trigger and signal channels will be simulated differently which solves the storage problem. Also, a fixed threshold is assumed rather than a noise riding one.

lpyras added 6 commits March 14, 2024 19:25

first draft of trigger

e9b0e99

update trigger to power integration and use sigmal value as threshold

af7f7ba

remove file with old name

89bf625

fix indentation error

6a9f386

really fixing indentation

34406d1

remove print statements

175eb24

lpyras requested review from sjoerd-bouma, cg-laser, colemanalan and jakobhenrichs April 27, 2024 20:48

anelles requested changes May 15, 2024

View reviewed changes

colemanalan requested changes May 20, 2024

View reviewed changes

lpyras added 2 commits August 14, 2024 15:35

add units and docstring, remove channel parameter storage

469844b

remove whitespace

4ab9921

remove old parametrization and trigger for the diode

e286a54

colemanalan requested changes Aug 16, 2024

View reviewed changes

improve docstrings

cf4f7af

colemanalan approved these changes Aug 16, 2024

View reviewed changes

lpyras closed this Sep 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Model of the diode trigger used for RNO-G #675

Model of the diode trigger used for RNO-G #675

lpyras commented Apr 27, 2024

anelles left a comment

anelles May 15, 2024

lpyras Aug 14, 2024

colemanalan May 19, 2024

lpyras Aug 14, 2024

colemanalan May 19, 2024

lpyras Aug 14, 2024

colemanalan May 19, 2024

lpyras Aug 14, 2024

colemanalan May 19, 2024

colemanalan May 19, 2024

lpyras Aug 14, 2024

colemanalan Aug 16, 2024

colemanalan May 19, 2024

colemanalan May 19, 2024

lpyras Aug 14, 2024

colemanalan May 20, 2024

lpyras Aug 14, 2024

colemanalan May 20, 2024

anelles commented Aug 8, 2024

lpyras commented Aug 14, 2024

colemanalan left a comment

colemanalan Aug 16, 2024

lpyras commented Aug 16, 2024

lpyras commented Sep 2, 2024

		self.sampling_rate = station.get_channel(det.get_channel_ids(station.get_id())[0]).get_sampling_rate()
		dt = 1. / self.sampling_rate

Model of the diode trigger used for RNO-G #675

Model of the diode trigger used for RNO-G #675

Conversation

lpyras commented Apr 27, 2024

anelles left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anelles commented Aug 8, 2024

lpyras commented Aug 14, 2024

colemanalan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lpyras commented Aug 16, 2024

lpyras commented Sep 2, 2024