Utility for gain, position and focusing factor correction

[sanyukta13]

Closed the pull request on modules, put in in utilities. Stopped using json files for positions

[cg-laser]

I'm not quite sure what this utility is supposed to do, so please correct me if some of my comments are wrong.

This seems to be very RNO-G specific. If this should be a general NuRadioReco utility, it needs to be generatlized a bit. Also some/many of the functions implement functionality which is already present in NuRadioReco, e.g. to calculate SNRs. This is handled by the channelSignalReconstructor. Or the bandapss filter.

The utility also needs very specific data files. Without these data files, the utility is useless.

Some of the functionality seems to be rather suited to be an RNO-G specific reconstruction module that corrects the data for certain effects.

Our way of taking antenna responses into account is through the antenna pattern class, where antenna responses are centrally defined. I suggest to use this interface.

In case this should stay a very RNO-G specific utility, I suggest to move it to the RNO-G github instead.

[sanyukta13]

I'm not quite sure what this utility is supposed to do, so please correct me if some of my comments are wrong.

This seems to be very RNO-G specific.

• It is RNO-G specific yes, do you have suggestions on alternate folders/place to push it?

If this should be a general NuRadioReco utility, it needs to be generatlized a bit. Also some/many of the functions implement functionality which is already present in NuRadioReco, e.g. to calculate SNRs. This is handled by the channelSignalReconstructor. Or the bandapss filter.

• SNR I was not aware of, I will check if it does the same task. I was using the noise_rms for SNR calculation, the part of the waveform before the pulse. I will check if it does a similar thing.

The utility also needs very specific data files. Without these data files, the utility is useless.

• Yes, one needs gain and density files, I am not sure then if I should put it on the utility

Some of the functionality seems to be rather suited to be an RNO-G specific reconstruction module that corrects the data for certain effects.

• Yes I agree it is RNO-G specific, please let me know if you can think of alternate and more suitable file paths

Our way of taking antenna responses into account is through the antenna pattern class, where antenna responses are centrally defined. I suggest to use this interface.

• I don't exactly know of antenna pattern class, can you refer me to the same?

In case this should stay a very RNO-G specific utility, I suggest to move it to the RNO-G github instead.

• Okay