Add unit test #643
Merged
Add unit test #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschlueter
force-pushed
the
add-unit-test
branch
from
289e13a
to
5d7c2cf
Compare
|
ping |
Comment on lines
+4
to
+5
| python3 NuRadioReco/detector/test/test_response.py |
There was a problem hiding this comment.
I think this won't work reliably - if the first python script raises an error, the second one will probably still run, and the github test will only consider the output of the second test. Feel free to put this into a new test, I think.
There was a problem hiding this comment.
I see thanks! I fixed it in the workflow yaml. Would that work?
|
ping |
|
@cg-laser maybe you can approve this? |
sjoerd-bouma
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the Response class. So far only the multiply operator functionality is tests ....
Based on PR #635. Solves #642