-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation refactor #586
base: develop
Are you sure you want to change the base?
Simulation refactor #586
Conversation
…simulation_refactor
…ndidate shower was found
… in Veff unit test
@christophwelling Haven't had a proper look at this yet, but it's probably worth merging in the latest develop - the tests (including the documentation) should complete successfully on those. |
…simulation_refactor
The tests seem to work, but the documentation fails because of some class for ARA. |
I don't think the ARA import is what breaks the documentation, but I'll take full responsibility for the documentation script somehow still being unable to properly sort the error messages. These are errors that should actually be fixed:
Looks like one missing module ( |
@christophwelling, what I can already say is that the branch is not compatible with |
I understand that you probably wanted to first just refactor the code without changing the functionality. However, should we not also cut "loose ends"? E.g.,
|
The new "subclasses" like |
I believe we haven't yet had a full release with this deprecation warning included, so I think we should keep it for 2.2.0 and only fully deprecate it in a future version. |
This is the refactor of the simulation.py script:
set_event_group
andset_event
.I'm going to write some documentation about how this is supposed to work once the documentation builds properly again.