feat(gradle): gradle atomizer #26663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a6484f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
7 times, most recently
from
b0d072c
to
165ea74
Compare
xiongemi
requested review from
philipjfulcher,
bcabanes and
MaxKless
as code owners
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
165ea74
to
4e71af1
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
4e71af1
to
985e712
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
985e712
to
9ae5588
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
9ae5588
to
289bbba
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
289bbba
to
b9ad060
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
b9ad060
to
0357401
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
3 times, most recently
from
22f5a04
to
192d5cb
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
192d5cb
to
9438420
Compare
xiongemi
force-pushed
the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
from
9438420
to
a6484f9
Compare
FrozenPandaz
approved these changes
Jul 5, 2024
| @@ -58,6 +58,7 @@ function addPlugin(tree: Tree) { | |||
| plugin: '@nx/gradle', | |||
| options: { | |||
| testTargetName: 'test', | |||
| ciTargetName: 'test-ci', | |||
There was a problem hiding this comment.
Don't do this yet. It can be enabled manually for now.
packages/gradle/src/plugin/nodes.ts
Outdated
| testTargetName?: string; | ||
| classesTargetName?: string; | ||
| buildTargetName?: string; | ||
| [taskTargetName: string]: string | undefined; | ||
| } | ||
|
|
||
| function normalizeOptions(options: GradlePluginOptions): GradlePluginOptions { | ||
| options ??= {}; | ||
| options.ciTargetName ??= 'test-ci'; |
There was a problem hiding this comment.
Don't set this by default. It should be the same as jest where we don't set it by default, but people can update their nx.json manually.
packages/gradle/src/plugin/nodes.ts
Outdated
| const inputsMap = createInputsMap(context); | ||
|
|
||
| const targets: Record<string, TargetConfiguration> = {}; | ||
| const targetGroups: Record<string, string[]> = {}; | ||
| for (const task of tasks) { | ||
| const targetName = options?.[`${task.name}TargetName`] ?? task.name; | ||
|
|
||
| const outputs = outputDirs.get(task.name); | ||
| if (task.name === 'test') { | ||
| const testFiles = await globWithWorkspaceContext( |
There was a problem hiding this comment.
Move this inside getTestTargets
packages/gradle/src/plugin/nodes.ts
Outdated
| } | ||
| targetGroups[taskType].push(testTargetName); | ||
|
|
||
| if (!testFiles || testFiles.length === 0) { |
There was a problem hiding this comment.
We will need a check for if they have ciTargetName. If not, don't glob and don't add targets. If yes, glob and add targets.
packages/gradle/src/plugin/nodes.ts
Outdated
| dependsOn: dependsOnMap['test'], | ||
| metadata: { | ||
| technologies: ['gradle'], | ||
| description: `Runs Gradle Tests ${testName} in CI`, |
There was a problem hiding this comment.
Suggested change
| description: `Runs Gradle Tests ${testName} in CI`, | |
| description: `Runs tests for the ${testName} class`, |
FrozenPandaz
deleted the
feature/nxc-736-implement-atomizing-gradle-test-targets
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #