Enclose arguments in quotes to ensure position #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, passing a blank value as input may result in unexpected behavior because the arguments are not guaranteed to exist in the specific position. This commit fixes this issue by enclosing arguments in quotes to ensure that all provided arguments are passed correctly. Signed-off-by: Sunghoon Kang <[email protected]>
|
This should be fixed with #98. Sorry and thank you for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, passing a blank value as input may result in unexpected behavior because the arguments are not guaranteed to exist in the specific position. (For example, we can pass empty value to
last-successful-eventfor fetching all type of events.)This commit fixes this issue by enclosing arguments in quotes to ensure that all provided arguments are passed correctly.