-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf noup] boards: Add non secure target for nrf54L15dk #2015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this marked as a noup
?
boards/nordic/nrf54l15dk/board.cmake
Outdated
set_property(TARGET runners_yaml_props_target PROPERTY hex_file tfm_merged.hex) | ||
endif() | ||
|
||
include(${ZEPHYR_BASE}/boards/common/nrfjprog.board.cmake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include(${ZEPHYR_BASE}/boards/common/nrfjprog.board.cmake) |
(No) thanks for the nice little trap. 😉
3be829e
to
ea36c10
Compare
ea36c10
to
96dfaab
Compare
96dfaab
to
d23b4f8
Compare
d23b4f8
to
e0647fb
Compare
c9c967a
to
e577710
Compare
e577710
to
7789165
Compare
Can someone from the reviewer list review this PR? |
@@ -98,7 +98,7 @@ to be build as multicore configuration with code snippet called ``vpr_launcher`` | |||
for the application core. | |||
|
|||
Enter the following command to compile ``hello_world`` for the FLPR core:: | |||
west build -p -b nrf54l15pdk/nrf54l15/cpuflpr --sysbuild -- -DSB_VPR_LAUNCHER=y | |||
west build -p -b nrf54l15dk/nrf54l15/cpuflpr --sysbuild -- -DSB_VPR_LAUNCHER=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be corrected upstream, not in this noup commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True.
7789165
to
fe6a2ca
Compare
ee8cb0f
to
a3321bd
Compare
This adds the nrf54l15dk/nrf54l15/cpuapp/ns board variant to sdk-zephyr. It allows to build nRF54l15dk with TF-M in nRF Connect SDK. This is done as a noup as the out-of-tree board extension feature is not available. When zephyrproject-rtos/zephyr#69548 is completed this commit can be reverted and the variant be placed in sdk-nrf. Signed-off-by: Tomi Fontanilles <[email protected]>
a3321bd
to
c74c200
Compare
This adds the nrf54l15dk/nrf54l15/cpuapp/ns board variant to sdk-zephyr. It allows to build nRF54l15dk with TF-M in nRF Connect SDK.
This is done as a noup as the out-of-tree board extension feature is not available. When zephyrproject-rtos/zephyr#69548 is completed this commit can be reverted and the variant be placed in sdk-nrf.