[nrf noup] soc: nrf54l: Disable CRACEN RAMs on system off #1983
Conversation
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
Vge0rge
force-pushed
the
memconf_config
branch
from
9c7bac0
to
1374c3a
Compare
Vge0rge
force-pushed
the
memconf_config
branch
2 times, most recently
from
dd4a1e8
to
bc4c35a
Compare
| nrf_memconf_ramblock_ret_mask_enable_set(NRF_MEMCONF, 1, (1 << 2), false); | ||
| nrf_memconf_ramblock_ret_mask_enable_set(NRF_MEMCONF, 1, (1 << 3), false); |
There was a problem hiding this comment.
Could those (1 << X) be defines to explain what they are?
There was a problem hiding this comment.
Could MEMCONF_POWER_RET_MEM2_Msk, MEMCONF_POWER_RET_MEM3_Msk and MEMCONF_POWER_CONTROL_MEM2_Msk and MEMCONF_POWER_CONTROL_MEM3_Msk be utilized for this?
There was a problem hiding this comment.
Please don't mix MDK defines with HAL functions, if you think those masks are needed we can add them to HAL.
There was a problem hiding this comment.
Yeah, I will not mix these up indeed. But I will write some more description on the bits that I am setting now that I got a confirmation from the spec writers that it is ok to do so.
| nrf_memconf_ramblock_ret_mask_enable_set(NRF_MEMCONF, 1, (1 << 2), false); | ||
| nrf_memconf_ramblock_ret_mask_enable_set(NRF_MEMCONF, 1, (1 << 3), false); |
There was a problem hiding this comment.
Could MEMCONF_POWER_RET_MEM2_Msk, MEMCONF_POWER_RET_MEM3_Msk and MEMCONF_POWER_CONTROL_MEM2_Msk and MEMCONF_POWER_CONTROL_MEM3_Msk be utilized for this?
Vge0rge
force-pushed
the
memconf_config
branch
from
bc4c35a
to
c411b55
Compare
Configure the CRACEN internal RAMs to avoid being retained during system off. Exiting system off triggers a system level reset so there is no need for the CRACEN RAMs to be retained during that. Also don't retain the CRACEN RAMs in system on idle if CRACEN is not used at all. Noup since the upstream code is not TFM aware yet and the edited function does not exist upstream. Ref: NCSDK-27427 Signed-off-by: Georgios Vasilakis <[email protected]>
Vge0rge
force-pushed
the
memconf_config
branch
from
c411b55
to
537ed7d
Compare
Configure the CRACEN internal RAMs to avoid being retained during system off. Exiting system off triggers a system level reset so there is no need for the CRACEN RAMs to be retained during that.
Noup since the upstream code is not TFM aware yet and the edited function does not exist upstream.