Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf upmerge] crypto: enable missing key type #607

Closed

Conversation

RobertGalatNordic
Copy link
Collaborator

enable CHACHA20

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: pull/16860/head

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

enable CHACHA20

Signed-off-by: Robert Gałat <[email protected]>
@github-actions github-actions bot added the source PR changing src files label Sep 16, 2024
@RobertGalatNordic RobertGalatNordic marked this pull request as draft September 16, 2024 10:45
Copy link
Contributor

@ktaborowski ktaborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it enables nrfconnect/sdk-nrf#16860, it might go
But afaik Sidewalk doesn't require ChaCha20 algo - it uses AES-GCM. So it should be some indirect dependency, which should be set automatically.

@ktaborowski ktaborowski changed the title crypto: enable missing key type [nrf upmerge] crypto: enable missing key type Sep 17, 2024
@ktaborowski
Copy link
Contributor

Closing as it won't solve all the issues with new upmerge. Might be reopen if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source PR changing src files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants