-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NRFX SPI bus implementation for Sidewalk #606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MarGasiorek
force-pushed
the
sid_nrfx_spi
branch
from
September 13, 2024 14:54
85b82e5
to
9dad261
Compare
MarGasiorek
force-pushed
the
sid_nrfx_spi
branch
2 times, most recently
from
September 16, 2024 06:52
7e5cdc2
to
256ae6d
Compare
RobertGalatNordic
approved these changes
Sep 16, 2024
ktaborowski
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, please make sure there is no regression
MarGasiorek
force-pushed
the
sid_nrfx_spi
branch
from
September 16, 2024 09:06
256ae6d
to
054ef29
Compare
SPI bus implementation based on the NRFX for nRF52840. Signed-off-by: Marcin Gasiorek <[email protected]>
MarGasiorek
force-pushed
the
sid_nrfx_spi
branch
from
September 16, 2024 09:09
054ef29
to
9997de6
Compare
github-actions
bot
added
the
doc-required
PR must not be merged without tech writer approval.
label
Sep 16, 2024
MarGasiorek
force-pushed
the
sid_nrfx_spi
branch
from
September 16, 2024 11:49
82dc8df
to
62ba185
Compare
ktaborowski
approved these changes
Sep 16, 2024
MarGasiorek
force-pushed
the
sid_nrfx_spi
branch
2 times, most recently
from
September 17, 2024 06:59
a73e7ce
to
c98f793
Compare
Add migration guide for PAL serial BUS for nRF52840. Signed-off-by: Marcin Gasiorek <[email protected]>
MarGasiorek
force-pushed
the
sid_nrfx_spi
branch
from
September 17, 2024 06:59
c98f793
to
ff453f8
Compare
totyz
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test PASSED
includes review and some structure changes Signed-off-by: Anna Wojdylo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPI bus implementation based on the NRFX for Sidewalk.
CI parameters
Description
Generally this PR helps to improve SPI communication (for nRF52) thus FSK experience as well.
JIRA ticket: KRKNWK-19259
Self review