Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRFX SPI bus implementation for Sidewalk #606

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

MarGasiorek
Copy link
Contributor

@MarGasiorek MarGasiorek commented Sep 13, 2024

SPI bus implementation based on the NRFX for Sidewalk.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

Generally this PR helps to improve SPI communication (for nRF52) thus FSK experience as well.
JIRA ticket: KRKNWK-19259

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Sep 13, 2024
@MarGasiorek MarGasiorek marked this pull request as ready for review September 13, 2024 14:01
Copy link

github-actions bot commented Sep 13, 2024

Sample diff used total
nrf52840dk/nrf52840:sample.sidewalk.demo RAM -160 B 118.66 KB 0 B
ROM -4.81 KB 431.69 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM -160 B 142.24 KB 0 B
ROM -4.89 KB 495.96 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM -160 B 142.22 KB 0 B
ROM -4.89 KB 487.49 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM -160 B 119.83 KB 0 B
ROM -4.81 KB 446.38 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM -160 B 103.68 KB 0 B
ROM -3.63 KB 363.95 KB 0 B

Copy link
Contributor

@ktaborowski ktaborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, please make sure there is no regression

subsys/sal/sid_pal/src/CMakeLists.txt Outdated Show resolved Hide resolved
SPI bus implementation based on the NRFX for nRF52840.

Signed-off-by: Marcin Gasiorek <[email protected]>
@MarGasiorek MarGasiorek force-pushed the sid_nrfx_spi branch 2 times, most recently from a73e7ce to c98f793 Compare September 17, 2024 06:59
Add migration guide for PAL serial BUS for nRF52840.

Signed-off-by: Marcin Gasiorek <[email protected]>
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test PASSED

@totyz totyz removed source PR changing src files scripts labels Sep 17, 2024
includes review and some structure changes

Signed-off-by: Anna Wojdylo <[email protected]>
@github-actions github-actions bot added the source PR changing src files label Sep 17, 2024
@totyz totyz removed the source PR changing src files label Sep 17, 2024
@MarGasiorek MarGasiorek merged commit eb292eb into nrfconnect:main Sep 17, 2024
55 of 56 checks passed
@MarGasiorek MarGasiorek deleted the sid_nrfx_spi branch September 17, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants