-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed448 key size 456 bits #18
base: main
Are you sure you want to change the base?
Conversation
e7c8e4e
to
296d081
Compare
@@ -270,7 +270,7 @@ | |||
#elif defined(PSA_WANT_ECC_MONTGOMERY_448) | |||
#define PSA_VENDOR_ECC_MAX_CURVE_BITS 448u | |||
#elif defined(PSA_WANT_ECC_TWISTED_EDWARDS_448) | |||
#define PSA_VENDOR_ECC_MAX_CURVE_BITS 448u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, this must be moved above the PSA_WANT_ECC_MONTGOMERY_448 since it's bigger
296d081
to
556875c
Compare
please add [nrf noup] in the commit message |
556875c
to
deb0c4b
Compare
Can you also add the description in your PR to the commit message? So that we can track what's happening from git without using github? |
RFC8032 mentions the length of a key for ed448 and ed448ph to be 57 bytes (456 bits). Using 448 bits as a max length creates a buffer overflow warning when building with ED448 enabled.
deb0c4b
to
73908de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
It seems from spec rfc8032 The length of a key for ed448 and ed448ph is 57 bytes (456 bits).
Using 448 bits as a max length creates a buffer overflow warning when building with ED448 enabled.