wifi: radio_test: Add timeout parameter for capture mode #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imapa
added
DNM
imapa
requested review from
udaynordic,
rajb9,
srkanordic,
krish2718,
sachinthegreen,
rado17 and
rlubos
as code owners
This was referenced Jun 26, 2024
sachinthegreen
requested changes
Jul 1, 2024
imapa
force-pushed
the
nrxlib_rx_cap_timeout
branch
from
bdd7554
to
91d79c9
Compare
sachinthegreen
requested changes
Jul 9, 2024
imapa
force-pushed
the
nrxlib_rx_cap_timeout
branch
from
91d79c9
to
7a055dd
Compare
sachinthegreen
approved these changes
Jul 11, 2024
udaynordic
approved these changes
Jul 11, 2024
imapa
force-pushed
the
nrxlib_rx_cap_timeout
branch
from
7a055dd
to
efba3ac
Compare
krish2718
changed the title
krish2718
requested changes
Jul 11, 2024
| * 0: Packet detected | ||
| * 1: Packet detection failed | ||
| */ | ||
| unsigned char timeout_status; |
There was a problem hiding this comment.
timeout and status are antonyms, i.e., timeout in general means lack of status. So, may be rename to capture_status? Also, it isn't quite clear from the comment the intent behind this?
imapa
force-pushed
the
nrxlib_rx_cap_timeout
branch
2 times, most recently
from
a2b0e47
to
187296e
Compare
krish2718
approved these changes
Jul 16, 2024
| *1: Capture failed after WLAN packet detection | ||
| *2: Capture timedout as no WLAN packets are detected | ||
| */ | ||
| unsigned char capture_status; |
There was a problem hiding this comment.
cap_status inline with other params?
prsi98
force-pushed
the
nrxlib_rx_cap_timeout
branch
5 times, most recently
from
cb754b0
to
df16933
Compare
[SHEL-2811]: Added command to get user-specified timeout in seconds.Rx samples will be displayed only when the capture occurs before the timeout lapses. Signed-off-by: Mahammadyunus Patil <[email protected]>
prsi98
force-pushed
the
nrxlib_rx_cap_timeout
branch
from
df16933
to
8f2ac92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHEL-2811: Added command to get user-specified timeout in seconds.Rx samples will be displayed only when the capture occurs before the timeout lapses.