nrf_wifi: Create dedicated memory pools for Wi-Fi #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
reviewed
May 3, 2024
| @@ -60,7 +60,7 @@ static enum nrf_wifi_status nrf_wifi_fmac_init_tx(struct nrf_wifi_fmac_dev_ctx * | |||
| def_priv->data_config.max_tx_aggregation * | |||
| sizeof(struct nrf_wifi_fmac_buf_map_info)); | |||
|
|
|||
| def_dev_ctx->tx_buf_info = nrf_wifi_osal_mem_zalloc(fmac_dev_ctx->fpriv->opriv, | |||
| def_dev_ctx->tx_buf_info = nrf_wifi_osal_pkt_mem_zalloc(fmac_dev_ctx->fpriv->opriv, | |||
There was a problem hiding this comment.
My preference would be to use data instead of pkt, but not a requirement.
There was a problem hiding this comment.
Also shouldn't there be a corresponding ctrl variant now? Or better yet, why not just pass a mem_pool_type parameter to the memory functions?
rado17
force-pushed
the
dedicated_mem_pool
branch
3 times, most recently
from
53c4e85
to
f47633e
Compare
Create dedicated memory pools for Wi-Fi data and management paths. Introduce corresponding memory allocation/deallocation calls. Signed-off-by: Ravi Dondaputi <[email protected]>
rado17
force-pushed
the
dedicated_mem_pool
branch
from
f47633e
to
08becd6
Compare
There was a problem hiding this comment.
@rado17 : As discussed please move this PR to Zephyr upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dedicated memory pools for Wi-Fi data and
management paths. Introduce corresponding memory
allocation/deallocation calls.