Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zboss: libraries update #1229

Merged
merged 2 commits into from
Mar 5, 2024
Merged

zboss: libraries update #1229

merged 2 commits into from
Mar 5, 2024

Conversation

edmont
Copy link
Contributor

@edmont edmont commented Feb 26, 2024 •
edited
Loading

ZBOSS libraries updates:

  • Remove ZBOSS development libraries and deprecate ZIGBEE_LIBRARY_DEVELOPMENT configuration.
  • Update ZBOSS production libraries with bugfixes.

@edmont edmont added this to the 2.6.0 milestone Feb 26, 2024
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Feb 26, 2024
@edmont
Copy link
Contributor Author

edmont commented Feb 26, 2024

Opening this PR as draft with the intention of extending it with bugfixes update and only then trigger the testing.

@greg-fer or @wiba-nordic please take a look to the doc changes in case another approach would be preferred.

wiba-nordic
wiba-nordic requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with this approach.

zboss/README.rst Show resolved Hide resolved
zboss/doc/zboss_configuration.rst Outdated Show resolved Hide resolved
zboss/doc/zboss_configuration.rst Outdated Show resolved Hide resolved
greg-fer
greg-fer reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning any updates to https://docs.nordicsemi.com/bundle/ncs-latest/page/nrfxlib/zboss/README.html and its documentation https://developer.nordicsemi.com/nRF_Connect_SDK/doc/zboss/index.html ?

@edmont
Copy link
Contributor Author

edmont commented Feb 27, 2024

Are you planning any updates to https://docs.nordicsemi.com/bundle/ncs-latest/page/nrfxlib/zboss/README.html and its documentation https://developer.nordicsemi.com/nRF_Connect_SDK/doc/zboss/index.html ?

Yes, they should be updated.

wiba-nordic
wiba-nordic requested changes Feb 28, 2024
View reviewed changes
zboss/doc/zboss_configuration.rst Outdated Show resolved Hide resolved
@greg-fer
Copy link
Contributor

Are you planning any updates to https://docs.nordicsemi.com/bundle/ncs-latest/page/nrfxlib/zboss/README.html and its documentation https://developer.nordicsemi.com/nRF_Connect_SDK/doc/zboss/index.html ?

Yes, they should be updated.

OK, can you point me to the PR in Bitbucket with the integration of the new version of the ZBOSS stack? Thanks.

@edmont edmont force-pushed the pr/zboss-libs branch 2 times, most recently from e168670 to a0276ed Compare February 29, 2024 12:25
@edmont edmont marked this pull request as ready for review February 29, 2024 12:31
@edmont edmont requested a review from milewr as a code owner February 29, 2024 12:31
@NordicBuilder NordicBuilder mentioned this pull request Feb 29, 2024
Merged
@edmont edmont added the bugfix label Feb 29, 2024
wiba-nordic
wiba-nordic requested changes Feb 29, 2024
View reviewed changes
zboss/CHANGELOG.rst Outdated Show resolved Hide resolved
zboss/CHANGELOG.rst Outdated Show resolved Hide resolved
zboss/CHANGELOG.rst Outdated Show resolved Hide resolved
wiba-nordic
wiba-nordic approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good to me.

@edmont
Copy link
Contributor Author

edmont commented Feb 29, 2024

Just removed previously added unneeded libraries.

@edmont edmont added the DNM Do not merge label Mar 1, 2024
@edmont
Copy link
Contributor Author

edmont commented Mar 1, 2024

Setting DNM while performing thorough testing.

@jfischer-no
Copy link

⏳ @edmont Please ping me when it is ready.

@edmont
zboss: remove ZBOSS development libraries
abd784b 
Remove ZBOSS development libraries and deprecate
`ZIGBEE_LIBRARY_DEVELOPMENT` configuration.

Signed-off-by: Eduardo Montoya <[email protected]>
@edmont
zboss: version v3.11.3.0+5.1.4
74e3225 
- ZBOSS sources: 5c339a77a158b29b0072141573e9f7e661cac96c

Signed-off-by: Eduardo Montoya <[email protected]>
@edmont edmont removed the DNM Do not merge label Mar 5, 2024
@jfischer-no jfischer-no merged commit 5ad13ee into nrfconnect:main Mar 5, 2024
3 checks passed
@edmont edmont deleted the pr/zboss-libs branch March 5, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-fer greg-fer greg-fer left review comments

@milewr milewr milewr approved these changes

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@AdamZelikNS AdamZelikNS AdamZelikNS approved these changes

Assignees
No one assigned
Labels
bugfix doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@edmont @greg-fer @jfischer-no @AdamZelikNS @wiba-nordic @milewr