Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_modem: doc: sockets: add info on CID and CONN_SAVE socket options #1051

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

eivindj-nordic
Copy link
Contributor

Expand the CID, CID_STATUS and CONN_SAVE socket option documentation.

@eivindj-nordic eivindj-nordic self-assigned this Jul 12, 2023
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jul 12, 2023
Copy link
Contributor

@lemrey lemrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@b-gent b-gent requested a review from wiba-nordic July 20, 2023 08:15
nrf_modem/doc/sockets.rst Outdated Show resolved Hide resolved
nrf_modem/doc/sockets.rst Outdated Show resolved Hide resolved
nrf_modem/doc/sockets.rst Outdated Show resolved Hide resolved
@eivindj-nordic
Copy link
Contributor Author

@wiba-nordic I've addressed your comments. Please have another look :)

@wiba-nordic
Copy link
Contributor

Looks good, I'll wait for doc build to finish before approving.

Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, we're on nrfxlib not ncs.

Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a manifest PR (nrfxlib CI does not build documentation).

CMakeLists.txt Outdated Show resolved Hide resolved
zephyr/module.yml Outdated Show resolved Hide resolved
Expand the CID, CID_STATUS and CONN_SAVE socket option documentation.

Signed-off-by: Eivind Jølsgard <[email protected]>
@anangl anangl merged commit a5d2ea0 into nrfconnect:main Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants