-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_modem: doc: sockets: add info on CID and CONN_SAVE socket options #1051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
c27c17c
to
b00444d
Compare
@wiba-nordic I've addressed your comments. Please have another look :) |
Looks good, I'll wait for doc build to finish before approving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, we're on nrfxlib not ncs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open a manifest PR (nrfxlib CI does not build documentation).
b00444d
to
a4c5a0f
Compare
a4c5a0f
to
0c921db
Compare
Expand the CID, CID_STATUS and CONN_SAVE socket option documentation. Signed-off-by: Eivind Jølsgard <[email protected]>
0c921db
to
bbb009c
Compare
Expand the CID, CID_STATUS and CONN_SAVE socket option documentation.