Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: openthread: rpc: using nrf_rpc encoders and decoders on servers #18531

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alxelax
Copy link
Contributor

@alxelax alxelax commented Nov 4, 2024

PR:

  1. adds using encoders and decoders on ot servers;
  2. makes using common decoding error handler
  3. reverts get_uint_t refactoring to be endianness tolerant

@alxelax alxelax requested a review from a team as a code owner November 4, 2024 15:32
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 4, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 93b8b4a8c779f8f2cd55987b17ff3e9e7cd7adbe

more details

sdk-nrf:

PR head: 93b8b4a8c779f8f2cd55987b17ff3e9e7cd7adbe
merge base: ebf1059fe62bb6942718b01910f73008c010130f
target head (main): 6c93155f8f1ecaff1909f2ac1c1cff6127ae38db
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (13)
subsys
│  ├── net
│  │  ├── openthread
│  │  │  ├── rpc
│  │  │  │  ├── client
│  │  │  │  │  ├── ot_rpc_coap.c
│  │  │  │  │  │ ot_rpc_diag.c
│  │  │  │  ├── common
│  │  │  │  │  ├── ot_rpc_common.c
│  │  │  │  │  │ ot_rpc_common.h
│  │  │  │  ├── server
│  │  │  │  │  ├── ot_rpc_cli.c
│  │  │  │  │  ├── ot_rpc_if.c
│  │  │  │  │  ├── ot_rpc_instance.c
│  │  │  │  │  ├── ot_rpc_ip6.c
│  │  │  │  │  ├── ot_rpc_link.c
│  │  │  │  │  ├── ot_rpc_message.c
│  │  │  │  │  ├── ot_rpc_netdata.c
│  │  │  │  │  ├── ot_rpc_thread.c
│  │  │  │  │  │ ot_rpc_udp.c

Outputs:

Toolchain

Version: b44b7a08c9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b44b7a08c9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 531
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-thread
    • ⚠️ test-fw-nrfconnect-ps
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

Commit adds refactoring openthread servers to use
nrf_rpc encoders and decoders instead of zcbor API.

Signed-off-by: Aleksandr Khromykh <[email protected]>
Using common decoding error handler for all commands
and responses.

Signed-off-by: Aleksandr Khromykh <[email protected]>
Commit reverts get_uint_t decoder to keep client
endianness tolerant.

Signed-off-by: Aleksandr Khromykh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants