Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support nRF54L15 + nRF7002 to AWS IoT sample #18074

Closed
wants to merge 15 commits into from
Closed

Add support nRF54L15 + nRF7002 to AWS IoT sample #18074

wants to merge 15 commits into from

Conversation

jtguggedal
Copy link
Contributor

@jtguggedal jtguggedal commented Oct 22, 2024 •
edited
Loading

Adds support for nRF54L15 PDK in combination with nRF7002 EK.

The PR is still in draft because it's based on #18066 . Please only review the latest commit touching AWS IoT sample.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 22, 2024
@jtguggedal jtguggedal changed the title Add AWS IoT support for nRF54L15 + nRF7002 Add support nRF54L15 + nRF7002 to AWS IoT sample Oct 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ❌ Toolchain
  • ❌ Build twister
  • ❌ Integration tests

Note: This message is automatically posted and updated by the CI

@jtguggedal jtguggedal added this to the 2.8.0 milestone Oct 22, 2024
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@bf32f98 (main) nrfconnect/sdk-nrfxlib#1525 nrfconnect/sdk-nrfxlib#1525/files
zephyr nrfconnect/sdk-zephyr@8ceab93 nrfconnect/sdk-zephyr#2142 nrfconnect/sdk-zephyr#2142/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

krish2718
krish2718 reviewed Oct 22, 2024
View reviewed changes
samples/net/aws_iot/boards/nrf54l15dk_nrf54l15_cpuapp.overlay
@@ -0,0 +1,22 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we just use the snippet nrf70-wifi for this and the conf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. Using the snippet causes a RAM overflow of 25 KB. The only way I have found to override heap increase caused by the snippet is to set cmake variables on the command line. But then the snippet causes stack overflows because it reduces shell, system workqueue and ISR stacks.

It looks like the snippet is only usable for samples in samples/wifi/ that do not require for instance TLS and where it is okay to reduce the stacks.

samples/net/aws_iot/boards/nrf54l15dk_nrf54l15_cpuapp.conf
# Heap sizes
CONFIG_HEAP_MEM_POOL_IGNORE_MIN=y
CONFIG_MBEDTLS_HEAP_SIZE=54000
CONFIG_HEAP_MEM_POOL_SIZE=87000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please note this should cover both nRF70 driver and WPA supplciant (it now used k_heap)

krish2718 and others added 14 commits October 23, 2024 03:32
@krish2718
manifest: sdk-zephyr: Wi-Fi upmerge
86b2cd3 
Pull changes for Wi-Fi upmerge for 2.8.0.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
manifest: nrfxlib: Pull updated FW blobs
243b3f7 
The FW blobs have been updated for upmerge.

Signed-off-by: Chaitanya Tata <[email protected]>
@rado17 @krish2718
subsys: nrf_security: Support Wi-Fi enterprise mode connection
d47cc68 
Enable support required for Wi-Fi enterprise mode connection.

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17 @krish2718
samples: wifi: shell: Support enterprise mode build
e973aa3 
Introduce a new overlay to build enterprise mode support.
Increase kernel heap to accommodate the enterprise mode
feature.

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17 @krish2718
samples: wifi: shell: Add enterprise mode build test
2352330 
Add enterprise mode support for twister runs.

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17 @krish2718
net: wifi_credentials: Add support for EAP-TLS configuration
ed9e8cd 
Add support to configure EAP-TLS method in Wi-Fi credentials.
Add getopt support to `add` command to facilitate extending the
configuration options.

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17 @krish2718
net: wifi_mgmt_ext: Add support for EAP-TLS method
aaf257f 
Add support to read identity and private key password if
configured in Enterprise mode.

Signed-off-by: Ravi Dondaputi <[email protected]>
@kapbh @krish2718
wifi: samples: Add offloaded raw tx mode sample
b69b146 
This sample demonstrates the offloaded raw TX packet
functionality of the nRF70 device.

Signed-off-by: Kapil Bhatt <[email protected]>
@rado17 @krish2718
samples: wifi: shell: Add overlay for enterprise mode
2d2ad0c 
Add overlay to enable enterprise mode configs.

Signed-off-by: Ravi Dondaputi <[email protected]>
@krish2718
samples: wifi: Remove fixed buffer size configuration
ac93c6a 
This fixes a Kconfig warning as nRF70 by default uses variable buffer
sizes.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
dts: bindings: Remove nRF70 bindings
3ceeed7 
These are now migrated upstream.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
net: lib: nrf70_fw_ext: Add Offloaded Raw TX support
f52829e 
This is a newly added FW patch variant.

Signed-off-by: Chaitanya Tata <[email protected]>
@rado17 @krish2718
doc: nrf: Create documentation for advanced Wi-Fi security modes.
7e0aa6f 
Create documentation for enterprise mode and PSA. Add entry in migration
guide for the syntax change in `wifi_cred add` command.

Signed-off-by: Ravi Dondaputi <[email protected]>
@krish2718
net: wifi_credentials: Fix commands mixup
8845098 
With the recent changes to Wi-Fi shell to use the separate command
declaration so that Wi-Fi commands can be extended externally, this
causes some sort of conflict with wifi_cred, possibly because both
command parent names start with "wifi", few commands from "wifi" end up
wth "wifi_cred".

As we debug the root cause, temporarily renamed the parent to
"nwifi_cred" to avoid this mixup, the shell command is still
"wifi_cred", so, this is acceptable.

Signed-off-by: Chaitanya Tata <[email protected]>
@jtguggedal
samples: net: aws_iot: Add support for nRF54L15 DK + nRF7002
e5cc591 
Adds support for nRF54L15 DK in combination with nRF7002 EK.

Signed-off-by: Jan Tore Guggedal <[email protected]>
divipillai
divipillai reviewed Oct 23, 2024
View reviewed changes
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
@@ -606,6 +606,10 @@ Networking samples

* Fixed not to fail with a fatal error if IPv4 or IPv6 server setup fails.

* :ref:`aws_iot` sample:

* Added support for the :ref:`zephyr:nrf54l15dk_nrf54l15` board in combination with an nRF7002-based shield.
Copy link
Contributor

@divipillai divipillai Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have some information about the nRF54l15 support in the introduction section, since we talk about other devices as well - https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/net/aws_iot/README.html.

Also, the configuration files section - https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/net/aws_iot/README.html#configuration_files would require an update about the nRF54l15 conf and overlay files.

simensrostad
simensrostad approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@simensrostad simensrostad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtguggedal
Copy link
Contributor Author

Superseded by #18120

@jtguggedal jtguggedal closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divipillai divipillai divipillai left review comments

@simensrostad simensrostad simensrostad approved these changes

@krish2718 krish2718 Awaiting requested review from krish2718 krish2718 is a code owner

@kapbh kapbh Awaiting requested review from kapbh kapbh will be requested when the pull request is marked ready for review kapbh is a code owner

@sachinthegreen sachinthegreen Awaiting requested review from sachinthegreen sachinthegreen will be requested when the pull request is marked ready for review sachinthegreen is a code owner

@D-Triveni D-Triveni Awaiting requested review from D-Triveni D-Triveni will be requested when the pull request is marked ready for review D-Triveni is a code owner

@muraliThokala muraliThokala Awaiting requested review from muraliThokala muraliThokala will be requested when the pull request is marked ready for review muraliThokala is a code owner

@bama-nordic bama-nordic Awaiting requested review from bama-nordic bama-nordic will be requested when the pull request is marked ready for review bama-nordic is a code owner

@rado17 rado17 Awaiting requested review from rado17 rado17 will be requested when the pull request is marked ready for review rado17 is a code owner

@wentong-li wentong-li Awaiting requested review from wentong-li wentong-li will be requested when the pull request is marked ready for review wentong-li is a code owner

Assignees
No one assigned
Labels
DNM doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib manifest-zephyr
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jtguggedal @NordicBuilder @simensrostad @divipillai @krish2718 @rado17 @kapbh