Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drivers: gpio: Add loopback test for eGPIO SDP #17173

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jaz1-nordic
Copy link
Contributor

@jaz1-nordic jaz1-nordic commented Sep 4, 2024

Added a loopback test for the software-defined eGPIO peripheral.
The test verifies proper operation of the eGPIO output by using
a different processor hardware GPIO input pin.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 4, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 14

Inputs:

Sources:

sdk-nrf: PR head: c6a414bed016430dc932db8cd576f2a326689cb0

more details

sdk-nrf:

PR head: c6a414bed016430dc932db8cd576f2a326689cb0
merge base: 7064aee2128799895ed5357f886a70ece2ec9f28
target head (main): 7064aee2128799895ed5357f886a70ece2ec9f28
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (12)
.github
│  │ test-spec.yml
CODEOWNERS
scripts
│  ├── ci
│  │  │ tags.yaml
tests
│  ├── drivers
│  │  ├── gpio
│  │  │  ├── egpio_basic_api
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── README.txt
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  ├── dts
│  │  │  │  │  ├── bindings
│  │  │  │  │  │  │ test-egpio.yaml
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  ├── test_egpio.h
│  │  │  │  │  │ test_egpio_port.c
│  │  │  │  ├── sysbuild.conf
│  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 42
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

applications/sw_io_devices/gpio/sample.yaml Outdated Show resolved Hide resolved
tests/drivers/gpio/egpio_basic_api/testcase.yaml Outdated Show resolved Hide resolved
tests/drivers/gpio/egpio_basic_api/testcase.yaml Outdated Show resolved Hide resolved
applications/sw_io_devices/gpio/sample.yaml Outdated Show resolved Hide resolved
applications/sw_io_devices/gpio/sample.yaml Outdated Show resolved Hide resolved
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@masz-nordic
Copy link
Contributor

This is a copy of tests/drivers/gpio/gpio_basic_api/src/test_gpio_port.c, correct?
Why not simply extend that test to use eGPIO instead of copying?

@jaz1-nordic
Copy link
Contributor Author

jaz1-nordic commented Sep 10, 2024

This is a copy of tests/drivers/gpio/gpio_basic_api/src/test_gpio_port.c, correct? Why not simply extend that test to use eGPIO instead of copying?

This file was the basis for my commit. However, eGPIO limitations (currently no input reading) forced changes that make this test incompatible with the original upstream and had to be added as a separate - eGPIO-only test case.
Additionally these are [nrf noup] changes. I was informed that we generally don't allow noups on samples/tests.
Things change too often there and making [nrf noup] is too expensive to maintain.

@masz-nordic
Copy link
Contributor

@PerMac @katgiadla can you take a look?

Copy link
Contributor

@nordic-piks nordic-piks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags are needed.

@nordic-piks
Copy link
Contributor

Please also add path for this new test into test-spec: https://github.com/nrfconnect/sdk-nrf/blob/main/.github/test-spec.yml#L583
so it will try to execute it at HW.

@masz-nordic masz-nordic added this to the 2.8.0 milestone Oct 9, 2024
@nrfconnect nrfconnect deleted a comment from NordicBuilder Oct 11, 2024
@jaz1-nordic jaz1-nordic requested a review from a team as a code owner October 11, 2024 12:05
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 11, 2024
Copy link
Contributor

@magp-nordic magp-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit note

Added a loopback test for the software-defined eGPIO peripheral.
The test verifies proper operation of the eGPIO output by using
a different processor hardware GPIO input pin.

Signed-off-by: Jakub Zymelka <[email protected]>
@rlubos
Copy link
Contributor

rlubos commented Oct 16, 2024

@nrfconnect/ncs-test-leads @nrfconnect/ncs-co-verification Ping

@magp-nordic
Copy link
Contributor

Icbmsg test case will have to be added after this or #17321 is merged

@PerMac PerMac merged commit 51cc6b5 into nrfconnect:main Oct 17, 2024
12 checks passed
@jaz1-nordic jaz1-nordic deleted the egpio-loop-test branch October 17, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.