wifi: Migrate to nRF70 upstream #16753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
krish2718
requested review from
trantanen,
tokangas,
a team,
rlubos,
ankuns,
martintv,
sachinthegreen,
D-Triveni,
muraliThokala,
bama-nordic,
rado17,
wentong-li,
plskeggs,
jayteemo,
glarsennordic,
jhirsi,
SeppoTakalo and
juhaylinen
as code owners
nRF70 now uses upstream Zephyr WPA supplicant. Signed-off-by: Chaitanya Tata <[email protected]>
Migrate to using Zephyr upstream. Signed-off-by: Chaitanya Tata <[email protected]>
This board is upstreamed to Zephyr. Signed-off-by: Chaitanya Tata <[email protected]>
These changes are necessary for migration of nRF70 to upstream. Signed-off-by: Chaitanya Tata <[email protected]>
nRF70 driver is the primary user for kernel heap and already sets a higher value which is typical, but for some configurations e.g., scan-only we need to set it to lower value to optimize memory, so, enable the option to ignore minimum mandated value from driver and instead use the value from the sample. Signed-off-by: Chaitanya Tata <[email protected]>
nRF70 upstream driver now needs more heap, not sure about the cause, but without this OOM messages during boot are seen. Signed-off-by: Chaitanya Tata <[email protected]>
Document changes that affect customer samples or applications. Signed-off-by: Chaitanya Tata <[email protected]>
Update Drivers, Wi-Fi protocols and documentation with notes about upstream migration. Signed-off-by: Chaitanya Tata <[email protected]>
With latest upstream, scan only mode now only works with nRF7000. Signed-off-by: Chaitanya Tata <[email protected]>
These are still unsupported in nRF70 upstream. Signed-off-by: Chaitanya Tata <[email protected]>
Pull fix an issue with 54L and nrfx 3.6.0.i Signed-off-by: Chaitanya Tata <[email protected]>
Remove the driver header dependency and inline the structures for now, this needs to be properly fixed in the future where nRF70 driver should have public headers. Signed-off-by: Chaitanya Tata <[email protected]>
With the upstream nRF70 driver, the co-ex is not auto-enabled based on the DTS, this was implemented improperly, now user has to explicitly choose to enable co-existence. Signed-off-by: Chaitanya Tata <[email protected]>
Almost all matter samples rely on PM which needs EXT_FLASH support for nRF70 which isn't supported yet, so, Quarnatine them for now. Signed-off-by: Chaitanya Tata <[email protected]>
TF-M still has few build issues with nrfx 3.6.0, so, temporarily disable. Signed-off-by: Chaitanya Tata <[email protected]>
Thingy is not supported yet for nRF70 companion chips. Signed-off-by: Chaitanya Tata <[email protected]>
Though these platforms are excluded for Wi-Fi tags, twister still fails as this is still part of integration platforms, remove it to fix the twister. Signed-off-by: Chaitanya Tata <[email protected]>
In latest nrfxlib this tag is removed, so, remove the reference to fix the doc build. Signed-off-by: Chaitanya Tata <[email protected]>
As of now the raw mode is couple with system mode which is unsupported for nRF7000, so, remove them. Signed-off-by: Chaitanya Tata <[email protected]>
Shutdown sample assumes default nRF70 mode is scan and doesn't support any other mode. With the migration to upstream scan only is limited to nRF7000 shield, so, remove other combinations. Also, add nRF7000 with 5340 as this was the main usecase for testing this sample. Signed-off-by: Chaitanya Tata <[email protected]>
These overflows are only happening in the CI, locally the same twister command works fine, quarantine them for now, and investigate later. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
use_nrf70_upstream
branch
from
53358f8
to
3fcd22a
Compare
sachinthegreen
approved these changes
Aug 22, 2024
|
This should not be merged by commeting test case without @endre-nordic approval |
Sure, after discussing with @bjarki-andreasen it was concluded to cherry-pick fixes from this PR to the upmerge PR and we can review it there. |
Merged
glarsennordic
suggested changes
Sep 16, 2024
| @@ -94,7 +94,7 @@ tests: | |||
| integration_platforms: | |||
| - nrf5340dk/nrf5340/cpuapp/ns | |||
| platform_allow: nrf5340dk/nrf5340/cpuapp/ns | |||
| extra_args: nrf_cloud_multi_service_SHIELD=nrf7002ek | |||
| extra_args: nrf_cloud_multi_service_SHIELD=nrf7002ek_nrf7000 | |||
There was a problem hiding this comment.
This is a connectivity build, not a scan-only build, so I think that means we should stick with nrf7002ek, right?
| @@ -84,7 +84,7 @@ tests: | |||
| - nrf9151dk/nrf9151/ns | |||
| - nrf9160dk/nrf9160/ns | |||
| - nrf9161dk/nrf9161/ns | |||
| extra_args: nrf_cloud_multi_service_SHIELD=nrf7002ek | |||
| extra_args: nrf_cloud_multi_service_SHIELD=nrf7002ek_nrf7000 | |||
There was a problem hiding this comment.
There are some references to this shield in `` that I think also need to be updated. They are all in the Building with nRF7002 Wi-Fi scanning support section.
Specifically, lines 797, 804. These should, if I am not mistaken, switch to using the nrf7002ek shield.
But beware, any mentions of the shield outside this section are for connectivity-enabled builds, so I don't think those need to change.
|
Any updates regarding this / regarding the upmerge? |
|
All changes in this PR are part of upmerge, any missing changes will be take care for 2.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream PR for nRF70 support (Boards, Drivers and hostap)
will soon beis merged and this PR removes nRF70 support from NCS and switches to use from Zephyr upstream.For now only nRF7002DK and EK (including variants) are supported, other shields (54 series, EB, Thingy etc) will be added later. Also, Firmware patches in external flash isn't supported, this will also be added later.
The invasive changes which are treewide are minor ones as below:
CONFIG_HEAP_MEM_POOL_IGNORE_MIN=y