Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: openthread: Add new featureset option. #14813

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

canisLupus1313
Copy link
Contributor

Commit adds new feature set option to nrfxlib and modifies RCP sample accordingly.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 11, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 11, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@220b37f nrfconnect/sdk-nrfxlib@8964805 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 11, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-fw-nrfconnect-thread X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@canisLupus1313 canisLupus1313 changed the title manifest: openthread: Add new festureset option. manifest: openthread: Add new featureset option. Apr 11, 2024
Copy link
Contributor

@edmont edmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docs:

  • configuring.rst
  • prebuilt_libs.rst
  • Sample's README.rst

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Apr 11, 2024
@canisLupus1313
Copy link
Contributor Author

Please update docs:

  • configuring.rst
  • prebuilt_libs.rst
  • Sample's README.rst

@edmont Should be fine now.

@wiba-nordic
Copy link
Contributor

Will take a look when the doc build finishes.

@edmont
Copy link
Contributor

edmont commented Apr 11, 2024

It will be also worth updating the release notes.

@wiba-nordic
Copy link
Contributor

The doc build seems to be broken by the libraries table:
obrazek

@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 11, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@canisLupus1313
Copy link
Contributor Author

@wiba-nordic The documentation has been built properly now.

@canisLupus1313 canisLupus1313 force-pushed the add_rcp_lib_option branch 2 times, most recently from 9621294 to f10857c Compare April 12, 2024 06:35
Commit adds new feature set option to nrfxlib and modifies RCP sample
accordingly.

Signed-off-by: Przemyslaw Bida <[email protected]>
@rlubos rlubos merged commit 3543283 into nrfconnect:main Apr 16, 2024
15 of 16 checks passed
@canisLupus1313 canisLupus1313 deleted the add_rcp_lib_option branch June 6, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants