[DRAFT] Get rid of FEM gain #14553
Closed
[DRAFT] Get rid of FEM gain #14553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MPSL FEM public API is changed. The `mpsl_fem_pa_gain_set` has been replaced by `mpsl_fem_pa_tx_control_set`. There is no more possibility of setting "gain". The real gain of FEM depends on many factors including but not limited to input power of the FEM, frequency, temperature, and the way the FEM is controlled. The fem_al API is changed so that the concept of generic "gain" of the front-end module is replaced by "tx_power_control" which is FEM type-specific. `fem_tx_power_control` type is introduced. `fem_tx_gain_set` is replaced by `fem_tx_power_control_set` `fem_default_tx_gain_get` is replaced by 'fem_default_tx_output_power_get' `fem_interface_api` is changed to reflect these changes along with implementations nrf21540.c and generic_fem.c Signed-off-by: Andrzej Kuros <[email protected]>
In the fem_al the "gain" of FEM is changed to "tx_power_control". This commit aligns to these changes. Due to these changes, the cli command `fem tx_gain <gain>` makes no more sense and is turned into: `fem tx_power_control <tx_power_control>` Signed-off-by: Andrzej Kuros <[email protected]>
In the fem_al the "gain" of FEM is changed to "tx_power_control". This commit aligns to these changes. Due to these changes, the DTM command FEM_GAIN_SET allowing to set "gain" of the FEM makes no more sense and is turned into: FEM_TX_POWER_CONTROL_SET allowing to set the FEM tx power control which is FEM type-specific. Signed-off-by: Andrzej Kuros <[email protected]>
This commit brings in softdevice_controller and MPSL with changed FEM public API. The `mpsl_fem_pa_gain_set` is replaced by `mpsl_fem_pa_control_set`. The concept of FEM "gain" is replaced by "pa_power_control" which is FEM type-specific. Signed-off-by: Andrzej Kuros <[email protected]>
This commit brings in nRF 802.15.4 Radio Driver aligned to changes made to MPSL FEM API. Signed-off-by: Andrzej Kuros <[email protected]>
github-actions
bot
added
doc-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
This PR brings in sdc,mpsl,nrf_802154 with change to FEM API.
The MPSL FEM public API is changed. The
mpsl_fem_pa_gain_sethas been replaced bympsl_fem_pa_tx_control_set. There is no more possibility of setting "gain". The real gain of FEM depends on many factors including but not limited to input power of the FEM, frequency, temperature, and the way the FEM is controlled.The "gain" (attempted to be FEM type-independent) is turned into "pa_power_control" parameter which is FEM type-specific.
The SDC & nrf_802154 are aligned and are not affected in their public interface in any way (just aligned to mentioned API change).
The radio_test and direct_test_mode are changed only when
CONFIG_RADIO_TEST_POWER_CONTROL_AUTOMATIC=nThe radio_test sample changes: the cli command
fem tx_gain <gain>makes no more sense and is turned into:fem tx_power_control <tx_power_control>which is FEM type-specific.The direct_test_mode sample is changed:
FEM_GAIN_SETwhich attempted to set FEM type-independent "gain" of the FEM makes no more sense and is turned into:FEM_TX_POWER_CONTROL_SETallowing to set the FEM tx power control signalling which is again FEM type-specific.